Prevent scale of 29 from postgresql hydration (paupino#647)

paupino · web-flow · commit 1a119c73e268 · 2024-02-10T20:21:46.000Z
diff --git a/src/postgres/common.rs b/src/postgres/common.rs
@@ -78,7 +78,7 @@ impl Decimal {
 
         result.set_sign_negative(neg);
         // Rescale to the postgres value, automatically rounding as needed.
-        result.rescale(scale as u32);
+        result.rescale((scale as u32).min(MAX_PRECISION_U32));
         result
     }
 
diff --git a/src/postgres/driver.rs b/src/postgres/driver.rs
@@ -255,6 +255,43 @@ mod test {
         assert_eq!(Decimal::ZERO, result);
     }
 
+    #[test]
+    fn read_small_unconstrained_numeric_type() {
+        let mut client = match Client::connect(&get_postgres_url(), NoTls) {
+            Ok(x) => x,
+            Err(err) => panic!("{:#?}", err),
+        };
+        let result: Decimal = match client.query("SELECT 0.100000000000000000000000000001::NUMERIC", &[]) {
+            Ok(x) => x.first().unwrap().get(0),
+            Err(err) => panic!("error - {:#?}", err),
+        };
+
+        // This gets rounded to 28 decimal places. In the future we may want to introduce a global feature which
+        // prevents rounding.
+        assert_eq!(result.to_string(), "0.1000000000000000000000000000");
+        assert_eq!(result.scale(), 28);
+    }
+
+    #[test]
+    fn read_small_unconstrained_numeric_type_addition() {
+        let mut client = match Client::connect(&get_postgres_url(), NoTls) {
+            Ok(x) => x,
+            Err(err) => panic!("{:#?}", err),
+        };
+        let (a, b): (Decimal, Decimal) = match client.query(
+            "SELECT 0.100000000000000000000000000001::NUMERIC, 0.00000000000014780214::NUMERIC",
+            &[],
+        ) {
+            Ok(x) => {
+                let row = x.first().unwrap();
+                (row.get(0), row.get(1))
+            }
+            Err(err) => panic!("error - {:#?}", err),
+        };
+
+        assert_eq!(a + b, Decimal::from_str("0.1000000000001478021400000000").unwrap());
+    }
+
     #[test]
     fn read_numeric_type() {
         let mut client = match Client::connect(&get_postgres_url(), NoTls) {

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ impl Decimal {`
`78`	`78`
`79`	`79`	`result.set_sign_negative(neg);`
`80`	`80`	`// Rescale to the postgres value, automatically rounding as needed.`
`81`		`- result.rescale(scale as u32);`
	`81`	`+ result.rescale((scale as u32).min(MAX_PRECISION_U32));`
`82`	`82`	`result`
`83`	`83`	`}`
`84`	`84`