Build Python 3.13 wheels, drop support for Python 3.7 #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dvarrazzo
reviewed
Oct 8, 2024
|
Trying to build the packages... 👀 |
By latest errors, it seems that Postgres 9.6 is no more supported on VS2019 image. By documentation, it also seem that Postgres 13 is the most recent supported database and not available in VS2015 image. Therefore, drop Python 3.8 test (and likely build). See https://www.appveyor.com/docs/services-databases/#postgresql
|
Looking into the build failure on appveyor. It seems like the database used for tests is too old, trying to use a more recent one. |
|
@dvarrazzo are there any more blockers? |
|
Yesterday I managed to run the test, but not the packaging. Trying that now. |
The runner image to build 3.8 package doesn't seem to have a currently supported database, and the previously used 9.6 is no more supported on current runners.
|
I managed to build packages on Windows too. We need to drop Python 3.8 but it doesn't seem a problem. There are a couple of little bugs I'd like to fix:
So I'd like to get those in and make a release. |
Paciupa
added a commit
to Paciupa/rabotaby_bot
that referenced
this pull request
Dec 26, 2024
Version `3.9` was chosen because of libraries compatibility: - Despite the documentation states that `psycopg2` supports version `3.8`, there are [no wheels](https://pypi.org/project/psycopg2/#files) for this version, and actually they [dropped support](psycopg/psycopg2#1729) for `3.8`. `psycopg2` was built successfully, but incorrectly with any Python version on Windows throwing `ImportError: DLL load failed while importing _psycopg: The specified module could not be found.` - `aiogram` [dropped](https://docs.aiogram.dev/en/v3.16.0/changelog.html#id10) `3.8` support. - adding support `3.8` makes `uv.lock` flile much more complex: more markers and plus 50% lines. Partly close #2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it quite difficult to continue building 3.7 wheels for macos. Maybe someone knows better.
See #1692.