Remove redundant autorequire

smortex · amitkarsale · commit cd67d1393378 · 2024-12-18T12:15:41.000+05:30
We already have a relationship in `manifests/server/instance/service.pp`
that ensure `Service["postgresqld_instance_${name}"]` is realized before
`Anchor["postgresql::server::service::end::${name}"]`.

Fun fact, removing this duplaciate fix the circular dependency reported
by puppet.
diff --git a/lib/puppet/type/postgresql_psql.rb b/lib/puppet/type/postgresql_psql.rb
@@ -138,10 +138,6 @@ def matches(value)
     ["postgresql::server::service::end::#{self[:instance]}"]
   end
 
-  autorequire(:service) do
-    ["postgresqld_instance_#{self[:instance]}"]
-  end
-
   def should_run_sql(refreshing = false)
     onlyif_param = @parameters[:onlyif]
     unless_param = @parameters[:unless]
