From 3a75aafdc27a8eca59e7ac5366d4bbe87b62d76c Mon Sep 17 00:00:00 2001
From: Tim Meusel <tim@bastelfreak.de>
Date: Mon, 28 Aug 2023 12:53:08 +0200
Subject: [PATCH] port parameter: Cleanup datatype

It doesn't make Sense to Allow Integer when we already allow
Stdlib::Port.
---
 REFERENCE.md                             | 24 ++++++++++++------------
 manifests/server.pp                      |  2 +-
 manifests/server/default_privileges.pp   |  2 +-
 manifests/server/extension.pp            |  2 +-
 manifests/server/grant.pp                |  2 +-
 manifests/server/grant_role.pp           |  2 +-
 manifests/server/instance/config.pp      |  2 +-
 manifests/server/instance/late_initdb.pp |  2 +-
 manifests/server/instance/passwd.pp      |  2 +-
 manifests/server/instance/service.pp     |  2 +-
 manifests/server/reassign_owned_by.pp    |  6 +++---
 manifests/server/role.pp                 |  2 +-
 manifests/server/table_grant.pp          |  2 +-
 13 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/REFERENCE.md b/REFERENCE.md
index fe3afd0e86..a19903bff8 100644
--- a/REFERENCE.md
+++ b/REFERENCE.md
@@ -1031,7 +1031,7 @@ Default value: `$postgresql::params::listen_addresses`
 
 ##### <a name="-postgresql--server--port"></a>`port`
 
-Data type: `Variant[String[1], Stdlib::Port, Integer]`
+Data type: `Variant[String[1], Stdlib::Port]`
 
 Specifies the port for the PostgreSQL server to listen on.
 Note: The same port number is used for all IP addresses the server listens on.
@@ -1946,7 +1946,7 @@ Default value: `$postgresql::server::psql_path`
 
 ##### <a name="-postgresql--server--default_privileges--port"></a>`port`
 
-Data type: `Variant[String[1], Stdlib::Port, Integer]`
+Data type: `Variant[String[1], Stdlib::Port]`
 
 Specifies the port to access the server. Default value: The default user for the module, usually '5432'.
 
@@ -2051,7 +2051,7 @@ Default value: `undef`
 
 ##### <a name="-postgresql--server--extension--port"></a>`port`
 
-Data type: `Optional[Variant[String[1], Stdlib::Port, Integer]]`
+Data type: `Optional[Variant[String[1], Stdlib::Port]]`
 
 Port to use when connecting.
 
@@ -2178,7 +2178,7 @@ Default value: `$postgresql::server::user`
 
 ##### <a name="-postgresql--server--grant--port"></a>`port`
 
-Data type: `Variant[String[1], Stdlib::Port, Integer]`
+Data type: `Variant[String[1], Stdlib::Port]`
 
 Port to use when connecting.
 
@@ -2280,7 +2280,7 @@ Default value: `$postgresql::server::user`
 
 ##### <a name="-postgresql--server--grant_role--port"></a>`port`
 
-Data type: `Variant[String[1], Stdlib::Port, Integer]`
+Data type: `Variant[String[1], Stdlib::Port]`
 
 Port to use when connecting.
 
@@ -2361,7 +2361,7 @@ Default value: `$postgresql::server::listen_addresses`
 
 ##### <a name="-postgresql--server--instance--config--port"></a>`port`
 
-Data type: `Variant[String[1], Stdlib::Port, Integer]`
+Data type: `Variant[String[1], Stdlib::Port]`
 
 Specifies the port for the PostgreSQL server to listen on.
 Note: The same port number is used for all IP addresses the server listens on. Also, for Red Hat systems and early Debian systems,
@@ -2785,7 +2785,7 @@ Default value: `$postgresql::server::psql_path`
 
 ##### <a name="-postgresql--server--instance--late_initdb--port"></a>`port`
 
-Data type: `Variant[String[1], Stdlib::Port, Integer]`
+Data type: `Variant[String[1], Stdlib::Port]`
 
 Specifies the port for the PostgreSQL server to listen on.
 Note: The same port number is used for all IP addresses the server listens on. Also, for Red Hat systems and early Debian systems,
@@ -2844,7 +2844,7 @@ Default value: `$postgresql::server::psql_path`
 
 ##### <a name="-postgresql--server--instance--passwd--port"></a>`port`
 
-Data type: `Variant[String[1], Stdlib::Port, Integer]`
+Data type: `Variant[String[1], Stdlib::Port]`
 
 Specifies the port for the PostgreSQL server to listen on.
 Note: The same port number is used for all IP addresses the server listens on. Also, for Red Hat systems and early Debian systems,
@@ -2982,7 +2982,7 @@ Default value: `$postgresql::server::user`
 
 ##### <a name="-postgresql--server--instance--service--port"></a>`port`
 
-Data type: `Variant[String[1], Stdlib::Port, Integer]`
+Data type: `Variant[String[1], Stdlib::Port]`
 
 Specifies the port for the PostgreSQL server to listen on.
 Note: The same port number is used for all IP addresses the server listens on. Also, for Red Hat systems and early Debian systems,
@@ -3219,7 +3219,7 @@ Default value: `$postgresql::server::user`
 
 ##### <a name="-postgresql--server--reassign_owned_by--port"></a>`port`
 
-Data type: `Variant[String[1], Stdlib::Port, Integer]`
+Data type: `Variant[String[1], Stdlib::Port]`
 
 Port to use when connecting.
 
@@ -3465,7 +3465,7 @@ Default value: `$postgresql::server::default_database`
 
 ##### <a name="-postgresql--server--role--port"></a>`port`
 
-Data type: `Optional[Variant[String[1], Stdlib::Port, Integer]]`
+Data type: `Optional[Variant[String[1], Stdlib::Port]]`
 
 Port to use when connecting.
 
@@ -3700,7 +3700,7 @@ Default value: `undef`
 
 ##### <a name="-postgresql--server--table_grant--port"></a>`port`
 
-Data type: `Optional[Variant[String[1], Stdlib::Port, Integer]]`
+Data type: `Optional[Variant[String[1], Stdlib::Port]]`
 
 Port to use when connecting.
 
diff --git a/manifests/server.pp b/manifests/server.pp
index 9239231379..71936b790f 100644
--- a/manifests/server.pp
+++ b/manifests/server.pp
@@ -135,7 +135,7 @@
   String[1]                                          $default_database             = $postgresql::params::default_database,
   Hash                                               $default_connect_settings     = $postgresql::globals::default_connect_settings,
   Optional[Variant[String[1], Array[String[1]]]]     $listen_addresses             = $postgresql::params::listen_addresses,
-  Variant[String[1], Stdlib::Port, Integer]          $port                         = $postgresql::params::port,
+  Variant[String[1], Stdlib::Port]                   $port                         = $postgresql::params::port,
   String[1]                                          $ip_mask_deny_postgres_user   = $postgresql::params::ip_mask_deny_postgres_user,
   String[1]                                          $ip_mask_allow_all_users      = $postgresql::params::ip_mask_allow_all_users,
   Array[String[1]]                                   $ipv4acls                     = $postgresql::params::ipv4acls,
diff --git a/manifests/server/default_privileges.pp b/manifests/server/default_privileges.pp
index 34c4475f66..cef1d541d9 100644
--- a/manifests/server/default_privileges.pp
+++ b/manifests/server/default_privileges.pp
@@ -28,7 +28,7 @@
   String                                    $schema            = 'public',
   String                                    $psql_db           = $postgresql::server::default_database,
   String                                    $psql_user         = $postgresql::server::user,
-  Variant[String[1], Stdlib::Port, Integer] $port              = $postgresql::server::port,
+  Variant[String[1], Stdlib::Port]          $port              = $postgresql::server::port,
   Hash                                      $connect_settings  = $postgresql::server::default_connect_settings,
   Enum['present', 'absent']                 $ensure            = 'present',
   String                                    $group             = $postgresql::server::group,
diff --git a/manifests/server/extension.pp b/manifests/server/extension.pp
index 9f28e3e85c..9594d9c388 100644
--- a/manifests/server/extension.pp
+++ b/manifests/server/extension.pp
@@ -29,7 +29,7 @@
   Optional[String[1]]                                 $version                = undef,
   Enum['present', 'absent']                           $ensure                 = 'present',
   Optional[String[1]]                                 $package_name           = undef,
-  Optional[Variant[String[1], Stdlib::Port, Integer]] $port                   = undef,
+  Optional[Variant[String[1], Stdlib::Port]]          $port                   = undef,
   Hash                                                $connect_settings       = postgresql::default('default_connect_settings'),
   String[1]                                           $database_resource_name = $database,
 ) {
diff --git a/manifests/server/grant.pp b/manifests/server/grant.pp
index c6bd7fe24b..56ee563330 100644
--- a/manifests/server/grant.pp
+++ b/manifests/server/grant.pp
@@ -41,7 +41,7 @@
   Array[String[1],0]                             $object_arguments  = [],
   String                                         $psql_db           = $postgresql::server::default_database,
   String                                         $psql_user         = $postgresql::server::user,
-  Variant[String[1], Stdlib::Port, Integer]      $port              = $postgresql::server::port,
+  Variant[String[1], Stdlib::Port]               $port              = $postgresql::server::port,
   Boolean                                        $onlyif_exists     = false,
   Hash                                           $connect_settings  = $postgresql::server::default_connect_settings,
   Enum['present', 'absent']                      $ensure            = 'present',
diff --git a/manifests/server/grant_role.pp b/manifests/server/grant_role.pp
index 92a82a5f0f..6f507a9b34 100644
--- a/manifests/server/grant_role.pp
+++ b/manifests/server/grant_role.pp
@@ -13,7 +13,7 @@
   Enum['present', 'absent']                 $ensure           = 'present',
   String[1]                                 $psql_db          = $postgresql::server::default_database,
   String[1]                                 $psql_user        = $postgresql::server::user,
-  Variant[String[1], Stdlib::Port, Integer] $port             = $postgresql::server::port,
+  Variant[String[1], Stdlib::Port]          $port             = $postgresql::server::port,
   Hash                                      $connect_settings = $postgresql::server::default_connect_settings,
 ) {
   case $ensure {
diff --git a/manifests/server/instance/config.pp b/manifests/server/instance/config.pp
index 84a51b5ae9..f34f896aaa 100644
--- a/manifests/server/instance/config.pp
+++ b/manifests/server/instance/config.pp
@@ -48,7 +48,7 @@
   String[1]                                      $ip_mask_deny_postgres_user   = $postgresql::server::ip_mask_deny_postgres_user,
   String[1]                                      $ip_mask_allow_all_users      = $postgresql::server::ip_mask_allow_all_users,
   Optional[Variant[String[1], Array[String[1]]]] $listen_addresses             = $postgresql::server::listen_addresses,
-  Variant[String[1], Stdlib::Port, Integer]      $port                         = $postgresql::server::port,
+  Variant[String[1], Stdlib::Port]               $port                         = $postgresql::server::port,
   Array[String[1]]                               $ipv4acls                     = $postgresql::server::ipv4acls,
   Array[String[1]]                               $ipv6acls                     = $postgresql::server::ipv6acls,
   Variant[String[1], Stdlib::Absolutepath]       $pg_hba_conf_path             = $postgresql::server::pg_hba_conf_path,
diff --git a/manifests/server/instance/late_initdb.pp b/manifests/server/instance/late_initdb.pp
index 09b5b42121..dcec18b63a 100644
--- a/manifests/server/instance/late_initdb.pp
+++ b/manifests/server/instance/late_initdb.pp
@@ -16,7 +16,7 @@
   String[1]                                 $user           = $postgresql::server::user,
   String[1]                                 $group          = $postgresql::server::group,
   Variant[String[1], Stdlib::Absolutepath]  $psql_path      = $postgresql::server::psql_path,
-  Variant[String[1], Stdlib::Port, Integer] $port           = $postgresql::server::port,
+  Variant[String[1], Stdlib::Port]          $port           = $postgresql::server::port,
   String[1]                                 $module_workdir = $postgresql::server::module_workdir,
 ) {
   # Set the defaults for the postgresql_psql resource
diff --git a/manifests/server/instance/passwd.pp b/manifests/server/instance/passwd.pp
index b4fdfb5384..526d55a9e4 100644
--- a/manifests/server/instance/passwd.pp
+++ b/manifests/server/instance/passwd.pp
@@ -17,7 +17,7 @@
   String[1]                                                   $user              = $postgresql::server::user,
   String[1]                                                   $group             = $postgresql::server::group,
   Variant[String[1], Stdlib::Absolutepath]                    $psql_path         = $postgresql::server::psql_path,
-  Variant[String[1], Stdlib::Port, Integer]                   $port              = $postgresql::server::port,
+  Variant[String[1], Stdlib::Port]                            $port              = $postgresql::server::port,
   String[1]                                                   $database          = $postgresql::server::default_database,
   String[1]                                                   $module_workdir    = $postgresql::server::module_workdir,
   Optional[Variant[String[1], Sensitive[String[1]], Integer]] $postgres_password = $postgresql::server::postgres_password,
diff --git a/manifests/server/instance/service.pp b/manifests/server/instance/service.pp
index 00e7010a90..48f5c603e7 100644
--- a/manifests/server/instance/service.pp
+++ b/manifests/server/instance/service.pp
@@ -25,7 +25,7 @@
   Optional[String[1]]                          $service_provider = $postgresql::server::service_provider,
   String[1]                                    $service_status   = $postgresql::server::service_status,
   String[1]                                    $user             = $postgresql::server::user,
-  Variant[String[1], Stdlib::Port, Integer]    $port             = $postgresql::server::port,
+  Variant[String[1], Stdlib::Port]             $port             = $postgresql::server::port,
   String[1]                                    $default_database = $postgresql::server::default_database,
   Variant[String[1], Stdlib::Absolutepath]     $psql_path        = $postgresql::server::psql_path,
   Hash                                         $connect_settings = $postgresql::server::default_connect_settings,
diff --git a/manifests/server/reassign_owned_by.pp b/manifests/server/reassign_owned_by.pp
index 4d5eac43d4..314381336f 100644
--- a/manifests/server/reassign_owned_by.pp
+++ b/manifests/server/reassign_owned_by.pp
@@ -12,9 +12,9 @@
   String $old_role,
   String $new_role,
   String $db,
-  String $psql_user                               = $postgresql::server::user,
-  Variant[String[1], Stdlib::Port, Integer] $port = $postgresql::server::port,
-  Hash $connect_settings                          = $postgresql::server::default_connect_settings,
+  String $psql_user                      = $postgresql::server::user,
+  Variant[String[1], Stdlib::Port] $port = $postgresql::server::port,
+  Hash $connect_settings                 = $postgresql::server::default_connect_settings,
 ) {
   $sql_command = "REASSIGN OWNED BY \"${old_role}\" TO \"${new_role}\""
 
diff --git a/manifests/server/role.pp b/manifests/server/role.pp
index dad17be125..968e806d5b 100644
--- a/manifests/server/role.pp
+++ b/manifests/server/role.pp
@@ -29,7 +29,7 @@
   Boolean                                             $createdb         = false,
   Boolean                                             $createrole       = false,
   String[1]                                           $db               = $postgresql::server::default_database,
-  Optional[Variant[String[1], Stdlib::Port, Integer]] $port             = undef,
+  Optional[Variant[String[1], Stdlib::Port]]          $port             = undef,
   Boolean                                             $login            = true,
   Boolean                                             $inherit          = true,
   Boolean                                             $superuser        = false,
diff --git a/manifests/server/table_grant.pp b/manifests/server/table_grant.pp
index 4ff0bd1ce8..69a1afa91d 100644
--- a/manifests/server/table_grant.pp
+++ b/manifests/server/table_grant.pp
@@ -19,7 +19,7 @@
   String[1]                                           $db,
   String[1]                                           $role,
   Optional[Enum['present', 'absent']]                 $ensure           = undef,
-  Optional[Variant[String[1], Stdlib::Port, Integer]] $port             = undef,
+  Optional[Variant[String[1], Stdlib::Port]]          $port             = undef,
   Optional[String[1]]                                 $psql_db          = undef,
   Optional[String[1]]                                 $psql_user        = undef,
   Optional[Hash]                                      $connect_settings = undef,

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/puppetlabs/puppetlabs-postgresql/pull/1471.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/puppetlabs/puppetlabs-postgresql/pull/1471.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/puppetlabs/puppetlabs-postgresql/pull/1471.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/puppetlabs/puppetlabs-postgresql/pull/1471.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>