Commit ca08f5f

and

authored

Customise merge behaviour depending on option. Fix #1803 (#1984)

Fix for #1803, where the method used for merging the config-settings option - string concatenation - was of little use. I broke out the TableFmt object into a protocol-like object called OptionFormat, where the formatting and merge rules can be customised more deeply. This is more explicit, and lets us be a bit more precise with how TOML object get converted into the options. I intend to use the flexibility of the OptionsFormat structure to tackle the remaining abiguity around environment variable quoting, as seen in the xfails in the options_test.py unit test and discussed in #1271. Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>

1 parent 229029e commit ca08f5fCopy full SHA for ca08f5f

3 files changed

+251

-148

lines changed

cibuildwheel
- options.py
unit_test
- options_test.py
- options_toml_test.py

3 files changed

+251

-148

lines changed

Comments

(0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit ca08f5f

3 files changed

3 files changed

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

File tree

3 files changed

3 files changed

0 commit comments

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.