gh-92886: Fix tests that fail when running with optimizations (-O) in test_zipimport.py (GH-93236)

miss-islington · jackh-ncl · web-flow · commit 0aa9ec9f5d11 · 2022-06-10T16:25:53.000-07:00
(cherry picked from commit 484a235) Co-authored-by: jackh-ncl <1750152+jackh-ncl@users.noreply.github.com>
diff --git a/Lib/test/test_zipimport.py b/Lib/test/test_zipimport.py
@@ -654,7 +654,10 @@ def test(val):
         sys.path.insert(0, TEMP_ZIP)
         mod = importlib.import_module(TESTMOD)
         self.assertEqual(mod.test(1), 1)
-        self.assertRaises(AssertionError, mod.test, False)
+        if __debug__:
+            self.assertRaises(AssertionError, mod.test, False)
+        else:
+            self.assertEqual(mod.test(0), 0)
 
     def testImport_WithStuff(self):
         # try importing from a zipfile which contains additional
diff --git a/Misc/NEWS.d/next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst b/Misc/NEWS.d/next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst
@@ -0,0 +1 @@
+Fixing tests that fail when running with optimizations (``-O``) in ``test_zipimport.py``

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fixing tests that fail when running with optimizations (``-O``) in ``test_zipimport.py``