gh-117649: Fix file descriptor leak in (expected) failing test case (#117780)

colesbury · web-flow · commit 1b10efad66e9 · 2024-04-11T21:35:46.000Z
The test case is currently expected to fail in the free-threaded build.
However, it fails before it gets a chance to close the write end of
the pipe.
diff --git a/Lib/test/test_capi/test_misc.py b/Lib/test/test_capi/test_misc.py
@@ -2139,6 +2139,9 @@ def check(enabled, override):
             }
 
             r, w = os.pipe()
+            if Py_GIL_DISABLED:
+                # gh-117649: The test fails before `w` is closed
+                self.addCleanup(os.close, w)
             script = textwrap.dedent(f'''
                 from test.test_capi.check_config import run_singlephase_check
                 run_singlephase_check({override}, {w})

Original file line number	Diff line number	Diff line change
`@@ -2139,6 +2139,9 @@ def check(enabled, override):`
`2139`	`2139`	`}`
`2140`	`2140`
`2141`	`2141`	`r, w = os.pipe()`
	`2142`	`+ if Py_GIL_DISABLED:`
	`2143`	+ # gh-117649: The test fails before `w` is closed
	`2144`	`+ self.addCleanup(os.close, w)`
`2142`	`2145`	`script = textwrap.dedent(f'''`
`2143`	`2146`	`from test.test_capi.check_config import run_singlephase_check`
`2144`	`2147`	`run_singlephase_check({override}, {w})`