gh-127146: Fix Emscripten test suite when run with -uall

hoodmane · hoodmane · commit 3d49b3445d15 · 2025-04-04T17:38:38.000+02:00
Emscripten large file support works fine and is required for
`testZip64LargeFile` to work.

And skip more stack overflows
diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
@@ -1104,6 +1104,7 @@ def test_filter_pickle(self):
             self.check_iter_pickle(f1, list(f2), proto)
 
     @support.skip_wasi_stack_overflow()
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_filter_dealloc(self):
         # Tests recursive deallocation of nested filter objects using the
diff --git a/Lib/test/test_capi/test_misc.py b/Lib/test/test_capi/test_misc.py
@@ -411,10 +411,12 @@ def test_trashcan_subclass(self):
         for i in range(100):
             L = MyList((L,))
 
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_trashcan_python_class1(self):
         self.do_test_trashcan_python_class(list)
 
+    @support.skip_emscripten_stack_overflow()
     @support.requires_resource('cpu')
     def test_trashcan_python_class2(self):
         from _testcapi import MyList
diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py
@@ -4519,6 +4519,7 @@ class Oops(object):
         o.whatever = Provoker(o)
         del o
 
+    @support.skip_emscripten_stack_overflow()
     @support.skip_wasi_stack_overflow()
     @support.requires_resource('cpu')
     def test_wrapper_segfault(self):
diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
@@ -1428,6 +1428,7 @@ def g():
         self.assertIsInstance(exc, RecursionError, type(exc))
         self.assertIn("maximum recursion depth exceeded", str(exc))
 
+    @support.skip_emscripten_stack_overflow()
     @support.skip_wasi_stack_overflow()
     @cpython_only
     @support.requires_resource('cpu')
diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
@@ -553,7 +553,7 @@ def do_test(test, obj, abilities):
         for [test, abilities] in tests:
             with self.subTest(test):
                 if test == pipe_writer and not threading_helper.can_start_thread:
-                    skipTest()
+                    self.skipTest("Requires threading but threading not supported")
                 with test() as obj:
                     do_test(test, obj, abilities)
 
diff --git a/configure b/configure
diff --git a/configure.ac b/configure.ac
@@ -3158,10 +3158,6 @@ if test "$ac_cv_sizeof_off_t" -gt "$ac_cv_sizeof_long" -a \
 else
   have_largefile_support="no"
 fi
-dnl LFS does not work with Emscripten 3.1
-AS_CASE([$ac_sys_system],
-  [Emscripten], [have_largefile_support="no"]
-)
 AS_VAR_IF([have_largefile_support], [yes], [
   AC_DEFINE([HAVE_LARGEFILE_SUPPORT], [1],
   [Defined to enable large file support when an off_t is bigger than a long
