Skip to content

Commit 546baba

Browse files
bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) (GH-24042)
(cherry picked from commit ec31653) Co-authored-by: Dong-hee Na <donghee.na@python.org>
1 parent 8bef9eb commit 546baba

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

Lib/test/test_nntplib.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def _check_desc(desc):
8484
desc = self.server.description(self.GROUP_NAME)
8585
_check_desc(desc)
8686
# Another sanity check
87-
self.assertIn("Python", desc)
87+
self.assertIn(self.DESC, desc)
8888
# With a pattern
8989
desc = self.server.description(self.GROUP_PAT)
9090
_check_desc(desc)
@@ -296,6 +296,7 @@ class NetworkedNNTPTests(NetworkedNNTPTestsMixin, unittest.TestCase):
296296
NNTP_HOST = 'news.trigofacile.com'
297297
GROUP_NAME = 'fr.comp.lang.python'
298298
GROUP_PAT = 'fr.comp.lang.*'
299+
DESC = 'Python'
299300

300301
NNTP_CLASS = NNTP
301302

@@ -329,8 +330,11 @@ class NetworkedNNTP_SSLTests(NetworkedNNTPTests):
329330
# 400 connections per day are accepted from each IP address."
330331

331332
NNTP_HOST = 'nntp.aioe.org'
332-
GROUP_NAME = 'comp.lang.python'
333-
GROUP_PAT = 'comp.lang.*'
333+
# bpo-42794: aioe.test is one of the official groups on this server
334+
# used for testing: https://news.aioe.org/manual/aioe-hierarchy/
335+
GROUP_NAME = 'aioe.test'
336+
GROUP_PAT = 'aioe.*'
337+
DESC = 'test'
334338

335339
NNTP_CLASS = getattr(nntplib, 'NNTP_SSL', None)
336340

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Update test_nntplib to use offical group name of news.aioe.org for testing.
2+
Patch by Dong-hee Na.

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy