bpo-12202: Properly check MsiSummaryInfoGetProperty() calls in msilib (GH-13711)

ZackerySpytz · berkerpeksag · commit 549e55a3086d · 2019-06-01T03:16:20.000+03:00
diff --git a/Lib/test/test_msilib.py b/Lib/test/test_msilib.py
@@ -85,13 +85,22 @@ def test_get_property_vt_empty(self):
 
     def test_directory_start_component_keyfile(self):
         db, db_path = init_database()
+        self.addCleanup(unlink, db_path)
         self.addCleanup(db.Close)
         feature = msilib.Feature(db, 0, 'Feature', 'A feature', 'Python')
         cab = msilib.CAB('CAB')
         dir = msilib.Directory(db, cab, None, TESTFN, 'TARGETDIR',
                                'SourceDir', 0)
         dir.start_component(None, feature, None, 'keyfile')
 
+    def test_getproperty_uninitialized_var(self):
+        db, db_path = init_database()
+        self.addCleanup(unlink, db_path)
+        self.addCleanup(db.Close)
+        si = db.GetSummaryInformation(0)
+        with self.assertRaises(msilib.MSIError):
+            si.GetProperty(-1)
+
 
 class Test_make_id(unittest.TestCase):
     #http://msdn.microsoft.com/en-us/library/aa369212(v=vs.85).aspx
diff --git a/Misc/NEWS.d/next/Library/2019-05-31-15-53-34.bpo-12202.nobzc9.rst b/Misc/NEWS.d/next/Library/2019-05-31-15-53-34.bpo-12202.nobzc9.rst
@@ -0,0 +1,2 @@
+Fix the error handling in :meth:`msilib.SummaryInformation.GetProperty`. Patch
+by Zackery Spytz.
diff --git a/PC/_msi.c b/PC/_msi.c
@@ -571,6 +571,9 @@ summary_getproperty(msiobj* si, PyObject *args)
         status = MsiSummaryInfoGetProperty(si->h, field, &type, &ival,
             &fval, sval, &ssize);
     }
+    if (status != ERROR_SUCCESS) {
+        return msierror(status);
+    }
 
     switch(type) {
         case VT_I2:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fix the error handling in :meth:`msilib.SummaryInformation.GetProperty`. Patch
	`2`	`+by Zackery Spytz.`
Original file line number	Diff line number	Diff line change
`@@ -571,6 +571,9 @@ summary_getproperty(msiobj* si, PyObject *args)`
`571`	`571`	`status = MsiSummaryInfoGetProperty(si->h, field, &type, &ival,`
`572`	`572`	`&fval, sval, &ssize);`
`573`	`573`	`}`
	`574`	`+ if (status != ERROR_SUCCESS) {`
	`575`	`+ return msierror(status);`
	`576`	`+ }`
`574`	`577`
`575`	`578`	`switch(type) {`
`576`	`579`	`case VT_I2:`