[3.14] gh-133968: Add fast path to PyUnicodeWriter_WriteStr() (GH-133969) (#133971)

miss-islington · vstinner · web-flow · commit 5632e93f4675 · 2025-05-13T13:58:25.000Z
gh-133968: Add fast path to PyUnicodeWriter_WriteStr() (GH-133969) Don't call PyObject_Str() if the input type is str. (cherry picked from commit fe9f6e8) Co-authored-by: Victor Stinner <vstinner@python.org>
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -13954,7 +13954,12 @@ _PyUnicodeWriter_WriteStr(_PyUnicodeWriter *writer, PyObject *str)
 int
 PyUnicodeWriter_WriteStr(PyUnicodeWriter *writer, PyObject *obj)
 {
-    if (Py_TYPE(obj) == &PyLong_Type) {
+    PyTypeObject *type = Py_TYPE(obj);
+    if (type == &PyUnicode_Type) {
+        return _PyUnicodeWriter_WriteStr((_PyUnicodeWriter*)writer, obj);
+    }
+
+    if (type == &PyLong_Type) {
         return _PyLong_FormatWriter((_PyUnicodeWriter*)writer, obj, 10, 0);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -13954,7 +13954,12 @@ _PyUnicodeWriter_WriteStr(_PyUnicodeWriter writer, PyObject str)`
`13954`	`13954`	`int`
`13955`	`13955`	`PyUnicodeWriter_WriteStr(PyUnicodeWriter writer, PyObject obj)`
`13956`	`13956`	`{`
`13957`		`- if (Py_TYPE(obj) == &PyLong_Type) {`
	`13957`	`+ PyTypeObject *type = Py_TYPE(obj);`
	`13958`	`+ if (type == &PyUnicode_Type) {`
	`13959`	`+ return _PyUnicodeWriter_WriteStr((_PyUnicodeWriter*)writer, obj);`
	`13960`	`+ }`
	`13961`	`+`
	`13962`	`+ if (type == &PyLong_Type) {`
`13958`	`13963`	`return _PyLong_FormatWriter((_PyUnicodeWriter*)writer, obj, 10, 0);`
`13959`	`13964`	`}`
`13960`	`13965`