bpo-36140: Fix an incorrect check in msidb_getsummaryinformation() (GH-12074)

miss-islington · ZackerySpytz · web-flow · commit 6ba95c38c556 · 2019-03-07T10:39:34.000-08:00
(cherry picked from commit bf94cc7) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
diff --git a/PC/_msi.c b/PC/_msi.c
@@ -916,7 +916,7 @@ msidb_getsummaryinformation(msiobj *db, PyObject *args)
         return msierror(status);
 
     oresult = PyObject_NEW(struct msiobj, &summary_Type);
-    if (!result) {
+    if (!oresult) {
         MsiCloseHandle(result);
         return NULL;
     }

Original file line number	Diff line number	Diff line change
`@@ -916,7 +916,7 @@ msidb_getsummaryinformation(msiobj db, PyObject args)`
`916`	`916`	`return msierror(status);`
`917`	`917`
`918`	`918`	`oresult = PyObject_NEW(struct msiobj, &summary_Type);`
`919`		`- if (!result) {`
	`919`	`+ if (!oresult) {`
`920`	`920`	`MsiCloseHandle(result);`
`921`	`921`	`return NULL;`
`922`	`922`	`}`