bpo-35198 Fix C++ extension compilation on AIX

kadler · kadler · commit 7f7bc73bd260 · 2018-11-09T12:45:49.000-06:00
For C++ extensions, distutils tries to replace the C compiler with the
C++ compiler, but it assumes that C compiler is the first element after
any environment variables set. On AIX, linking goes through ld_so_aix,
so it is the first element and the compiler is the next element. Thus
the replacement is faulty:

ld_so_aix gcc ... -&gt; g++ gcc ...

Also, it assumed that self.compiler_cxx had only 1 element or that
there were the same number of elements as the linker has and in the
same order. This might not be the case, so instead concatenate
everything together.
diff --git a/Lib/distutils/unixccompiler.py b/Lib/distutils/unixccompiler.py
@@ -188,7 +188,10 @@ def link(self, target_desc, objects,
                         i = 1
                         while '=' in linker[i]:
                             i += 1
-                    linker[i] = self.compiler_cxx[i]
+                    if linker[i].endswith('ld_so_aix'):
+                        # Linker is ld_so_aix, so compiler is next arg
+                        i += 1
+                    linker = linker[:i] + self.compiler_cxx + linker[i+1:]
 
                 if sys.platform == 'darwin':
                     linker = _osx_support.compiler_fixup(linker, ld_args)
diff --git a/Misc/NEWS.d/next/Library/2018-11-09-12-45-28.bpo-35198.EJ8keW.rst b/Misc/NEWS.d/next/Library/2018-11-09-12-45-28.bpo-35198.EJ8keW.rst
@@ -0,0 +1 @@
+Fix C++ extension compilation on AIX
