fixup! Add tests for sampling profiler

lkollar · lkollar · commit aeca768f0862 · 2025-07-03T22:58:19.000+01:00
diff --git a/Lib/test/test_sample_profiler.py b/Lib/test/test_sample_profiler.py
@@ -11,14 +11,24 @@
 import unittest
 from unittest import mock
 
-import profile.sample
 from profile.pstats_collector import PstatsCollector
 from profile.stack_collectors import (
     CollapsedStackCollector,
 )
 
 from test.support.os_helper import unlink
 
+PROCESS_VM_READV_SUPPORTED = False
+
+try:
+    from _remote_debugging import PROCESS_VM_READV_SUPPORTED
+except ImportError:
+    raise unittest.SkipTest(
+        "Test only runs when _remote_debugging is available"
+    )
+else:
+    import profile.sample
+
 
 class MockFrameInfo:
     """Mock FrameInfo for testing since the real one isn't accessible."""
@@ -256,11 +266,13 @@ def test_pstats_collector_export(self):
         self.assertEqual(func1_stats[3], 2.0)  # ct (cumulative time)
 
 
+@unittest.skipIf(
+    sys.platform == "linux" and not PROCESS_VM_READV_SUPPORTED,
+    "Test only runs on Linux with process_vm_readv support",
+)
 class TestSampleProfilerIntegration(unittest.TestCase):
     @classmethod
     def setUpClass(cls):
-        cls.python_exe = sys.executable
-
         cls.test_script = '''
 import time
 import os
@@ -472,6 +484,10 @@ def test_sampling_all_threads(self):
         # We're not testing output format here
 
 
+@unittest.skipIf(
+    sys.platform == "linux" and not PROCESS_VM_READV_SUPPORTED,
+    "Test only runs on Linux with process_vm_readv support",
+)
 class TestSampleProfilerErrorHandling(unittest.TestCase):
     def test_invalid_pid(self):
         with self.assertRaises((OSError, RuntimeError)):
