[3.11] GH-104308: socket.getnameinfo should release the GIL (GH-104307) (#104313)

miss-islington · njsmith · blurb-it[bot] · web-flow · commit b7622e7a0544 · 2023-05-08T23:49:45.000Z
GH-104308: socket.getnameinfo should release the GIL (GH-104307) * socket.getnameinfo should release the GIL * 📜🤖 Added by blurb_it. --------- (cherry picked from commit faf1962) Co-authored-by: Nathaniel J. Smith <njs@pobox.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
diff --git a/Misc/NEWS.d/next/Library/2023-05-08-20-57-17.gh-issue-104307.DSB93G.rst b/Misc/NEWS.d/next/Library/2023-05-08-20-57-17.gh-issue-104307.DSB93G.rst
@@ -0,0 +1 @@
+:func:`socket.getnameinfo` now releases the GIL while contacting the DNS server
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
@@ -6737,8 +6737,10 @@ socket_getnameinfo(PyObject *self, PyObject *args)
         }
 #endif
     }
+    Py_BEGIN_ALLOW_THREADS
     error = getnameinfo(res->ai_addr, (socklen_t) res->ai_addrlen,
                     hbuf, sizeof(hbuf), pbuf, sizeof(pbuf), flags);
+    Py_END_ALLOW_THREADS
     if (error) {
         set_gaierror(error);
         goto fail;

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+:func:`socket.getnameinfo` now releases the GIL while contacting the DNS server
Original file line number	Diff line number	Diff line change
`@@ -6737,8 +6737,10 @@ socket_getnameinfo(PyObject self, PyObject args)`
`6737`	`6737`	`}`
`6738`	`6738`	`#endif`
`6739`	`6739`	`}`
	`6740`	`+ Py_BEGIN_ALLOW_THREADS`
`6740`	`6741`	`error = getnameinfo(res->ai_addr, (socklen_t) res->ai_addrlen,`
`6741`	`6742`	`hbuf, sizeof(hbuf), pbuf, sizeof(pbuf), flags);`
	`6743`	`+ Py_END_ALLOW_THREADS`
`6742`	`6744`	`if (error) {`
`6743`	`6745`	`set_gaierror(error);`
`6744`	`6746`	`goto fail;`