ZipFile.writestr now respect SOURCE_DATE_EPOCH

Wulian233 · Wulian233 · commit bc61e4476dc3 · 2024-09-24T20:31:22.000+08:00
diff --git a/Lib/zipfile/__init__.py b/Lib/zipfile/__init__.py
@@ -1904,8 +1904,10 @@ def writestr(self, zinfo_or_arcname, data,
         if isinstance(data, str):
             data = data.encode("utf-8")
         if not isinstance(zinfo_or_arcname, ZipInfo):
+            time_ = os.environ.get('SOURCE_DATE_EPOCH') or time.time()
+            date_time = time.gmtime(time_)[:6]
             zinfo = ZipInfo(filename=zinfo_or_arcname,
-                            date_time=time.localtime(time.time())[:6])
+                            date_time=date_time)
             zinfo.compress_type = self.compression
             zinfo.compress_level = self.compresslevel
             if zinfo.filename.endswith('/'):
diff --git a/Misc/NEWS.d/next/Library/2024-09-24-20-25-52.gh-issue-91279.9oMUwW.rst b/Misc/NEWS.d/next/Library/2024-09-24-20-25-52.gh-issue-91279.9oMUwW.rst
@@ -0,0 +1,3 @@
+``ZipFile.writestr`` now respect SOURCE_DATE_EPOCH, that distributions can
+set centrally and have build tools consume this in order to produce
+reproducible output.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+``ZipFile.writestr`` now respect SOURCE_DATE_EPOCH, that distributions can
	`2`	`+set centrally and have build tools consume this in order to produce`
	`3`	`+reproducible output.`