gh-133597: Fix memory leak if error occurred in _sys_getwindowsversion_from_kernel32 (GH-133598)

miss-islington · sergey-miryanov · web-flow · commit e0aefbd263c3 · 2025-05-08T11:32:59.000Z
(cherry picked from commit 0ec8fc8) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
diff --git a/Python/sysmodule.c b/Python/sysmodule.c
@@ -1693,6 +1693,9 @@ _sys_getwindowsversion_from_kernel32(void)
         !GetFileVersionInfoW(kernel32_path, 0, verblock_size, verblock) ||
         !VerQueryValueW(verblock, L"", (LPVOID)&ffi, &ffi_len)) {
         PyErr_SetFromWindowsErr(0);
+        if (verblock) {
+            PyMem_RawFree(verblock);
+        }
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1693,6 +1693,9 @@ _sys_getwindowsversion_from_kernel32(void)`
`1693`	`1693`	`!GetFileVersionInfoW(kernel32_path, 0, verblock_size, verblock) \|\|`
`1694`	`1694`	`!VerQueryValueW(verblock, L"", (LPVOID)&ffi, &ffi_len)) {`
`1695`	`1695`	`PyErr_SetFromWindowsErr(0);`
	`1696`	`+ if (verblock) {`
	`1697`	`+ PyMem_RawFree(verblock);`
	`1698`	`+ }`
`1696`	`1699`	`return NULL;`
`1697`	`1700`	`}`
`1698`	`1701`