Skip to content

collections.abc.ValuesView is not sufficently tested #98512

New issue
New issue
Closed
Closed
collections.abc.ValuesView is not sufficently tested#98512
Assignees
sobolevn
Labels
stdlibPython modules in the Lib dirtestsTests in the Lib/test dir
@sobolevn

Description

@sobolevn
sobolevn
opened on Oct 21, 2022

There are places where it is either not complete:

cpython/Lib/test/test_dictviews.py

Lines 338 to 340 in 49f6106

self.assertIsInstance(d.values(), collections.abc.ValuesView)
self.assertIsInstance(d.values(), collections.abc.MappingView)
self.assertIsInstance(d.values(), collections.abc.Sized)

Not base classes are covered here. But, I guess it should be.

Or there are places where it is not tested at all:

cpython/Lib/test/test_collections.py

Lines 1866 to 1869 in 49f6106

self.assertIsInstance(mymap.keys(), Set)
self.assertIsInstance(mymap.keys(), KeysView)
self.assertIsInstance(mymap.items(), Set)
self.assertIsInstance(mymap.items(), ItemsView)

I will go through places like this and cover ValuesView.
Noticed while working on #98511

Metadata

Metadata

Assignees

Labels

stdlibPython modules in the Lib dirtestsTests in the Lib/test dir

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions
    pFad - Phonifier reborn

    Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

    Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


    Alternative Proxies:

    Alternative Proxy

    pFad Proxy

    pFad v3 Proxy

    pFad v4 Proxy