From 0ff0444ee809c2bbf4dcbb6f55071a4dbc61f1ef Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 6 Jun 2023 14:55:50 +0200 Subject: [PATCH] gh-105376: Remove logging.Logger.warn() method --- Doc/library/logging.rst | 8 ++++---- Doc/whatsnew/3.13.rst | 6 ++++++ Lib/logging/__init__.py | 5 ----- .../2023-06-06-15-32-44.gh-issue-105376.W4oDQp.rst | 4 ++++ 4 files changed, 14 insertions(+), 9 deletions(-) create mode 100644 Misc/NEWS.d/next/Library/2023-06-06-15-32-44.gh-issue-105376.W4oDQp.rst diff --git a/Doc/library/logging.rst b/Doc/library/logging.rst index 22412e1a2113bb..d7a389fa13d6a0 100644 --- a/Doc/library/logging.rst +++ b/Doc/library/logging.rst @@ -275,6 +275,10 @@ is the module's name in the Python package namespace. .. versionchanged:: 3.8 The *stacklevel* parameter was added. + .. versionchanged:: 3.13 + Remove the undocumented ``warn()`` method which was an alias to the + :meth:`warning` method. + .. method:: Logger.info(msg, *args, **kwargs) @@ -287,10 +291,6 @@ is the module's name in the Python package namespace. Logs a message with level :const:`WARNING` on this logger. The arguments are interpreted as for :meth:`debug`. - .. note:: There is an obsolete method ``warn`` which is functionally - identical to ``warning``. As ``warn`` is deprecated, please do not use - it - use ``warning`` instead. - .. method:: Logger.error(msg, *args, **kwargs) Logs a message with level :const:`ERROR` on this logger. The arguments are diff --git a/Doc/whatsnew/3.13.rst b/Doc/whatsnew/3.13.rst index 35e6303c370e2f..1eb859f3a5af01 100644 --- a/Doc/whatsnew/3.13.rst +++ b/Doc/whatsnew/3.13.rst @@ -310,6 +310,12 @@ Removed use ``locale.setlocale(locale.LC_ALL, "")`` instead. (Contributed by Victor Stinner in :gh:`104783`.) +* Remove the undocumented and untested ``logging.Logger.warn()`` method, + deprecated since Python 3.3, which was an alias to the + :meth:`logging.Logger.warning` method: use the :meth:`logging.Logger.warning` + method instead. + (Contributed by Victor Stinner in :gh:`105376`.) + Porting to Python 3.13 ====================== diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py index 056380fb2287af..ba2ed44b095071 100644 --- a/Lib/logging/__init__.py +++ b/Lib/logging/__init__.py @@ -1550,11 +1550,6 @@ def warning(self, msg, *args, **kwargs): if self.isEnabledFor(WARNING): self._log(WARNING, msg, args, **kwargs) - def warn(self, msg, *args, **kwargs): - warnings.warn("The 'warn' method is deprecated, " - "use 'warning' instead", DeprecationWarning, 2) - self.warning(msg, *args, **kwargs) - def error(self, msg, *args, **kwargs): """ Log 'msg % args' with severity 'ERROR'. diff --git a/Misc/NEWS.d/next/Library/2023-06-06-15-32-44.gh-issue-105376.W4oDQp.rst b/Misc/NEWS.d/next/Library/2023-06-06-15-32-44.gh-issue-105376.W4oDQp.rst new file mode 100644 index 00000000000000..a7d3172ca4c642 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2023-06-06-15-32-44.gh-issue-105376.W4oDQp.rst @@ -0,0 +1,4 @@ +Remove the undocumented and untested ``logging.Logger.warn()`` method, +deprecated since Python 3.3, which was an alias to the +:meth:`logging.Logger.warning` method: use the :meth:`logging.Logger.warning` +method instead. Patch by Victor Stinner. pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy