-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-107453: Document errno.{ECANCELED,EOWNERDEAD,ENOTRECOVERABLE,ENOTSUP} #107486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
issue : #107453 |
I wonder about sorting -- this PR adds the new constants to the end, but there does seem to be rough numerical order currently (see A |
@AA-Turner I think sorting is dispensable because we can use "Ctrl+f" .😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the constants in order. Then people can either ctrl+F, or see things where they expect when they don't.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
@hugovk -- mea culpa! I should have looked at linux's ordering before leaving a comment, it transpires only one constant was out-of-order ( A |
I found
in linux/include/linux/errno.h But it seems that linux doesn't define ENOTSUP. Also this code's output
is
in linux. and is
in windows. Errno constants in windows(https://learn.microsoft.com/en-us/cpp/c-runtime-library/errno-constants?view=msvc-170) |
From the man page linked:
A |
Yes, I found it from https://lists.gnu.org/archive/html/bug-glibc/2002-08/msg00017.html
|
Thanks @qqwqqw689 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
This comment was marked as off-topic.
This comment was marked as off-topic.
…,ENOTSUP} (pythonGH-107486) (cherry picked from commit 1ac6423) Co-authored-by: qqwqqw689 <114795525+qqwqqw689@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-108529 is a backport of this pull request to the 3.12 branch. |
GH-108530 is a backport of this pull request to the 3.11 branch. |
…,ENOTSUP} (pythonGH-107486) (cherry picked from commit 1ac6423) Co-authored-by: qqwqqw689 <114795525+qqwqqw689@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
…E,ENOTSUP} (GH-107486) (#108529) gh-107453: Document errno.{ECANCELED,EOWNERDEAD,ENOTRECOVERABLE,ENOTSUP} (GH-107486) (cherry picked from commit 1ac6423) Co-authored-by: qqwqqw689 <114795525+qqwqqw689@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
📚 Documentation preview 📚: https://cpython-previews--107486.org.readthedocs.build/
errno
documentation missing several constants #107453