diff --git a/Lib/test/test_re.py b/Lib/test/test_re.py
index 0b710e3766ab82..5ef6d7b12c50a3 100644
--- a/Lib/test/test_re.py
+++ b/Lib/test/test_re.py
@@ -1516,8 +1516,18 @@ def test_ascii_and_unicode_flag(self):
self.assertRaises(re.error, re.compile, r'(?au)\w')
def test_locale_flag(self):
- import locale
- _, enc = locale.getlocale(locale.LC_CTYPE)
+ # On Windows, Python 3.7 doesn't call setlocale(LC_CTYPE, "") at
+ # startup and so the LC_CTYPE locale uses Latin1 encoding by default,
+ # whereas getpreferredencoding() returns the ANSI code page. Set
+ # temporarily the LC_CTYPE locale to the user preferred encoding to
+ # ensure that it uses the ANSI code page.
+ oldloc = locale.setlocale(locale.LC_CTYPE, None)
+ locale.setlocale(locale.LC_CTYPE, "")
+ self.addCleanup(locale.setlocale, locale.LC_CTYPE, oldloc)
+
+ # Get the current locale encoding
+ enc = locale.getpreferredencoding(False)
+
# Search non-ASCII letter
for i in range(128, 256):
try:
diff --git a/Misc/NEWS.d/next/Tests/2019-03-05-13-48-39.bpo-29571.ecGuKR.rst b/Misc/NEWS.d/next/Tests/2019-03-05-13-48-39.bpo-29571.ecGuKR.rst
new file mode 100644
index 00000000000000..f89aec5e8d52dc
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2019-03-05-13-48-39.bpo-29571.ecGuKR.rst
@@ -0,0 +1,6 @@
+Fix ``test_re.test_locale_flag()``: use ``locale.getpreferredencoding()``
+rather than ``locale.getlocale()`` to get the locale encoding. With some
+locales, ``locale.getlocale()`` returns the wrong encoding. On Windows, set
+temporarily the ``LC_CTYPE`` locale to the user preferred encoding to ensure
+that it uses the ANSI code page, to be consistent with
+``locale.getpreferredencoding()``.
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy