From a3fee7c12d6c48b91499f2c1f908fb44ee207ae3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=A9n=C3=A9dikt=20Tran?= <10796600+picnixz@users.noreply.github.com> Date: Sun, 12 Jan 2025 13:31:39 +0100 Subject: [PATCH 1/4] skip CI on CODEOWNERS update --- .github/workflows/reusable-change-detection.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/reusable-change-detection.yml b/.github/workflows/reusable-change-detection.yml index 964bd87e815f42..d047828c2482f3 100644 --- a/.github/workflows/reusable-change-detection.yml +++ b/.github/workflows/reusable-change-detection.yml @@ -83,7 +83,10 @@ jobs: # into the PR branch anyway. # # https://github.com/python/core-workflow/issues/373 - git diff --name-only "origin/$GITHUB_BASE_REF.." | grep -qvE '(\.rst$|^Doc|^Misc|^\.pre-commit-config\.yaml$|\.ruff\.toml$|\.md$|mypy\.ini$)' && echo "run-tests=true" >> "$GITHUB_OUTPUT" || true + git diff --name-only "origin/$GITHUB_BASE_REF.." | grep -qvE \ + -e '(\.rst$|\.md$|^Doc|^Misc|^CODEOWNERS$)' \ + -e '(^\.pre-commit-config\.yaml$|\.ruff\.toml$|mypy\.ini$)' \ + && echo "run-tests=true" >> "$GITHUB_OUTPUT" || true fi # Check if we should run hypothesis tests From 608f77fbb748b49d1c74eef07fd32a7a0d254864 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=A9n=C3=A9dikt=20Tran?= <10796600+picnixz@users.noreply.github.com> Date: Sun, 12 Jan 2025 13:34:52 +0100 Subject: [PATCH 2/4] fix pattern --- .github/workflows/reusable-change-detection.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-change-detection.yml b/.github/workflows/reusable-change-detection.yml index d047828c2482f3..39558a3d70b872 100644 --- a/.github/workflows/reusable-change-detection.yml +++ b/.github/workflows/reusable-change-detection.yml @@ -84,7 +84,7 @@ jobs: # # https://github.com/python/core-workflow/issues/373 git diff --name-only "origin/$GITHUB_BASE_REF.." | grep -qvE \ - -e '(\.rst$|\.md$|^Doc|^Misc|^CODEOWNERS$)' \ + -e '(\.rst$|\.md$|^Doc|^Misc|^\.github/CODEOWNERS$)' \ -e '(^\.pre-commit-config\.yaml$|\.ruff\.toml$|mypy\.ini$)' \ && echo "run-tests=true" >> "$GITHUB_OUTPUT" || true fi From 5308aeab6073d9698204627042a55db52d9b28a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=A9n=C3=A9dikt=20Tran?= <10796600+picnixz@users.noreply.github.com> Date: Mon, 13 Jan 2025 13:49:36 +0100 Subject: [PATCH 3/4] Store patterns into an array for readability --- .../workflows/reusable-change-detection.yml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/.github/workflows/reusable-change-detection.yml b/.github/workflows/reusable-change-detection.yml index 39558a3d70b872..99d1cc5f440dbc 100644 --- a/.github/workflows/reusable-change-detection.yml +++ b/.github/workflows/reusable-change-detection.yml @@ -83,9 +83,21 @@ jobs: # into the PR branch anyway. # # https://github.com/python/core-workflow/issues/373 - git diff --name-only "origin/$GITHUB_BASE_REF.." | grep -qvE \ - -e '(\.rst$|\.md$|^Doc|^Misc|^\.github/CODEOWNERS$)' \ - -e '(^\.pre-commit-config\.yaml$|\.ruff\.toml$|mypy\.ini$)' \ + grep_ignore_args=( + # file extensions + -e '\.rst$' + -e '\.md$' + # top-level folders + -e '^Doc/' + -e '^Misc/' + # configuration files + -e '^\.github/CODEOWNERS$' + -e '^\.pre-commit-config\.yaml$' + -e '\.ruff\.toml$' + -e 'mypy\.ini$' + ) + git diff --name-only "origin/$GITHUB_BASE_REF.." \ + | grep -qvE "${grep_ignore_args[@]}" \ && echo "run-tests=true" >> "$GITHUB_OUTPUT" || true fi From a3165d6397949a979fc4ccaff5275b61a4257b30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=A9n=C3=A9dikt=20Tran?= <10796600+picnixz@users.noreply.github.com> Date: Mon, 13 Jan 2025 14:49:44 +0100 Subject: [PATCH 4/4] Update .github/workflows/reusable-change-detection.yml Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> --- .github/workflows/reusable-change-detection.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-change-detection.yml b/.github/workflows/reusable-change-detection.yml index 99d1cc5f440dbc..c08c0cb8873f12 100644 --- a/.github/workflows/reusable-change-detection.yml +++ b/.github/workflows/reusable-change-detection.yml @@ -85,8 +85,8 @@ jobs: # https://github.com/python/core-workflow/issues/373 grep_ignore_args=( # file extensions - -e '\.rst$' -e '\.md$' + -e '\.rst$' # top-level folders -e '^Doc/' -e '^Misc/' pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy