From 4c389c901276ab1c6a649ffaed5c4767e1c9caba Mon Sep 17 00:00:00 2001
From: ctrlaltf2 <23644849+ctrlaltf2@users.noreply.github.com>
Date: Mon, 19 May 2025 14:07:15 -0400
Subject: [PATCH 1/2] gh-134261: Don't rely on local time for reproducible
builds & tests
---
Lib/test/test_zipfile/test_core.py | 2 +-
Lib/zipfile/__init__.py | 9 ++++++---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/Lib/test/test_zipfile/test_core.py b/Lib/test/test_zipfile/test_core.py
index 43056978848c03..fbeddd654cc00a 100644
--- a/Lib/test/test_zipfile/test_core.py
+++ b/Lib/test/test_zipfile/test_core.py
@@ -1812,7 +1812,7 @@ def test_write_with_source_date_epoch(self):
with zipfile.ZipFile(TESTFN, "r") as zf:
zip_info = zf.getinfo("test_source_date_epoch.txt")
- get_time = time.localtime(int(os.environ['SOURCE_DATE_EPOCH']))[:6]
+ get_time = time.gmtime(int(os.environ['SOURCE_DATE_EPOCH']))[:6]
# Compare each element of the date_time tuple
# Allow for a 1-second difference
for z_time, g_time in zip(zip_info.date_time, get_time):
diff --git a/Lib/zipfile/__init__.py b/Lib/zipfile/__init__.py
index 894b4d37233923..bc34309759e8ed 100644
--- a/Lib/zipfile/__init__.py
+++ b/Lib/zipfile/__init__.py
@@ -623,9 +623,12 @@ def _for_archive(self, archive):
Return self.
"""
# gh-91279: Set the SOURCE_DATE_EPOCH to a specific timestamp
- epoch = os.environ.get('SOURCE_DATE_EPOCH')
- get_time = int(epoch) if epoch else time.time()
- self.date_time = time.localtime(get_time)[:6]
+ source_date_epoch = os.environ.get('SOURCE_DATE_EPOCH')
+
+ if source_date_epoch:
+ self.date_time = time.gmtime(int(source_date_epoch))[:6]
+ else:
+ self.date_time = time.localtime(time.time())[:6]
self.compress_type = archive.compression
self.compress_level = archive.compresslevel
From e0fcc2d0eb4e83a43a16df242f1c0c5cf6871495 Mon Sep 17 00:00:00 2001
From: "blurb-it[bot]" <43283697+blurb-it[bot]@users.noreply.github.com>
Date: Mon, 19 May 2025 21:08:26 +0000
Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=93=9C=F0=9F=A4=96=20Added=20by=20blu?=
=?UTF-8?q?rb=5Fit.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
.../next/Library/2025-05-19-21-08-25.gh-issue-134261.ravGYm.rst | 1 +
1 file changed, 1 insertion(+)
create mode 100644 Misc/NEWS.d/next/Library/2025-05-19-21-08-25.gh-issue-134261.ravGYm.rst
diff --git a/Misc/NEWS.d/next/Library/2025-05-19-21-08-25.gh-issue-134261.ravGYm.rst b/Misc/NEWS.d/next/Library/2025-05-19-21-08-25.gh-issue-134261.ravGYm.rst
new file mode 100644
index 00000000000000..3791f9241355c6
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2025-05-19-21-08-25.gh-issue-134261.ravGYm.rst
@@ -0,0 +1 @@
+zip: On reproducible builds, ZipFile longer pulls in local environment timezone when writing file datetimes
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy