diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-07-01-20-17-38.bpo-1635741.-AtPYu.rst b/Misc/NEWS.d/next/Core and Builtins/2020-07-01-20-17-38.bpo-1635741.-AtPYu.rst
new file mode 100644
index 00000000000000..c529923779fa84
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2020-07-01-20-17-38.bpo-1635741.-AtPYu.rst
@@ -0,0 +1 @@
+Port :mod:`sha256` to multiphase initialization
diff --git a/Modules/sha256module.c b/Modules/sha256module.c
index 261f9daee28072..06e4430bd7c333 100644
--- a/Modules/sha256module.c
+++ b/Modules/sha256module.c
@@ -681,43 +681,45 @@ static struct PyMethodDef SHA_functions[] = {
{NULL, NULL} /* Sentinel */
};
-
-/* Initialize this module. */
-
-static struct PyModuleDef _sha256module = {
- PyModuleDef_HEAD_INIT,
- "_sha256",
- NULL,
- -1,
- SHA_functions,
- NULL,
- NULL,
- NULL,
- NULL
-};
-
-PyMODINIT_FUNC
-PyInit__sha256(void)
+static int sha256_exec(PyObject *module)
{
- PyObject *m;
-
Py_SET_TYPE(&SHA224type, &PyType_Type);
if (PyType_Ready(&SHA224type) < 0) {
- return NULL;
+ return -1;
}
Py_SET_TYPE(&SHA256type, &PyType_Type);
if (PyType_Ready(&SHA256type) < 0) {
- return NULL;
+ return -1;
}
- m = PyModule_Create(&_sha256module);
- if (m == NULL)
- return NULL;
-
Py_INCREF((PyObject *)&SHA224type);
- PyModule_AddObject(m, "SHA224Type", (PyObject *)&SHA224type);
+ if (PyModule_AddObject(module, "SHA224Type", (PyObject *)&SHA224type) < 0) {
+ Py_DECREF((PyObject *)&SHA224type);
+ return -1;
+ }
Py_INCREF((PyObject *)&SHA256type);
- PyModule_AddObject(m, "SHA256Type", (PyObject *)&SHA256type);
- return m;
+ if (PyModule_AddObject(module, "SHA256Type", (PyObject *)&SHA256type) < 0) {
+ Py_DECREF((PyObject *)&SHA256type);
+ return -1;
+ }
+ return 0;
+}
+
+static PyModuleDef_Slot _sha256_slots[] = {
+ {Py_mod_exec, sha256_exec},
+ {0, NULL}
+};
+
+static struct PyModuleDef _sha256module = {
+ PyModuleDef_HEAD_INIT,
+ .m_name = "_sha256",
+ .m_methods = SHA_functions,
+ .m_slots = _sha256_slots,
+};
+/* Initialize this module. */
+PyMODINIT_FUNC
+PyInit__sha256(void)
+{
+ return PyModuleDef_Init(&_sha256module);
}
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy