diff --git a/Lib/test/test_re.py b/Lib/test/test_re.py
index bd689582523c32..96d0cdb17a7ee3 100644
--- a/Lib/test/test_re.py
+++ b/Lib/test/test_re.py
@@ -2190,6 +2190,18 @@ class ImplementationTest(unittest.TestCase):
Test implementation details of the re module.
"""
+ @cpython_only
+ def test_immutable(self):
+ # bpo-43908: check that re types are immutable
+ with self.assertRaises(TypeError):
+ re.Match.foo = 1
+ with self.assertRaises(TypeError):
+ re.Pattern.foo = 1
+ with self.assertRaises(TypeError):
+ pat = re.compile("")
+ tp = type(pat.scanner(""))
+ tp.foo = 1
+
def test_overlap_table(self):
f = sre_compile._generate_overlap_table
self.assertEqual(f(""), [])
diff --git a/Misc/NEWS.d/next/Core and Builtins/2021-04-26-21-20-41.bpo-43908.2L51nO.rst b/Misc/NEWS.d/next/Core and Builtins/2021-04-26-21-20-41.bpo-43908.2L51nO.rst
new file mode 100644
index 00000000000000..1709351726f965
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2021-04-26-21-20-41.bpo-43908.2L51nO.rst
@@ -0,0 +1,2 @@
+Make :mod:`re` types immutable. Patch by
+Erlend E. Aasland.
diff --git a/Modules/_sre.c b/Modules/_sre.c
index d4bfff6e849e37..59f7551a227cd3 100644
--- a/Modules/_sre.c
+++ b/Modules/_sre.c
@@ -2690,7 +2690,7 @@ static PyType_Spec pattern_spec = {
.name = "re.Pattern",
.basicsize = sizeof(PatternObject),
.itemsize = sizeof(SRE_CODE),
- .flags = Py_TPFLAGS_DEFAULT,
+ .flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_IMMUTABLETYPE,
.slots = pattern_slots,
};
@@ -2755,7 +2755,7 @@ static PyType_Spec match_spec = {
.name = "re.Match",
.basicsize = sizeof(MatchObject),
.itemsize = sizeof(Py_ssize_t),
- .flags = Py_TPFLAGS_DEFAULT,
+ .flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_IMMUTABLETYPE,
.slots = match_slots,
};
@@ -2781,7 +2781,7 @@ static PyType_Slot scanner_slots[] = {
static PyType_Spec scanner_spec = {
.name = "_" SRE_MODULE ".SRE_Scanner",
.basicsize = sizeof(ScannerObject),
- .flags = Py_TPFLAGS_DEFAULT,
+ .flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_IMMUTABLETYPE,
.slots = scanner_slots,
};
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy