From ce9ace18c52e625a120e239c08b954e5bd378a73 Mon Sep 17 00:00:00 2001 From: Steve Dower Date: Wed, 2 Nov 2022 15:11:54 +0000 Subject: [PATCH] gh-98978: Fix use-after-free in apps that call pathconfig global functions multiple times --- .../2022-11-02-15-11-29.gh-issue-98978.Yl_gFA.rst | 3 +++ Python/pathconfig.c | 12 +++--------- 2 files changed, 6 insertions(+), 9 deletions(-) create mode 100644 Misc/NEWS.d/next/Security/2022-11-02-15-11-29.gh-issue-98978.Yl_gFA.rst diff --git a/Misc/NEWS.d/next/Security/2022-11-02-15-11-29.gh-issue-98978.Yl_gFA.rst b/Misc/NEWS.d/next/Security/2022-11-02-15-11-29.gh-issue-98978.Yl_gFA.rst new file mode 100644 index 00000000000000..aaaeba6a7e61c2 --- /dev/null +++ b/Misc/NEWS.d/next/Security/2022-11-02-15-11-29.gh-issue-98978.Yl_gFA.rst @@ -0,0 +1,3 @@ +Fixed a potential use-after-free in applications that call configuration +functions :c:func:`Py_SetPythonHome`, :c:func:`Py_SetProgramName` or +(private) ``_Py_SetProgramFullPath`` multiple times. diff --git a/Python/pathconfig.c b/Python/pathconfig.c index 69b7e10a3b0288..761185c27c6703 100644 --- a/Python/pathconfig.c +++ b/Python/pathconfig.c @@ -261,9 +261,7 @@ Py_SetPythonHome(const wchar_t *home) _PyMem_SetDefaultAllocator(PYMEM_DOMAIN_RAW, &old_alloc); PyMem_RawFree(_Py_path_config.home); - if (has_value) { - _Py_path_config.home = _PyMem_RawWcsdup(home); - } + _Py_path_config.home = has_value ? _PyMem_RawWcsdup(home) : NULL; PyMem_SetAllocator(PYMEM_DOMAIN_RAW, &old_alloc); @@ -282,9 +280,7 @@ Py_SetProgramName(const wchar_t *program_name) _PyMem_SetDefaultAllocator(PYMEM_DOMAIN_RAW, &old_alloc); PyMem_RawFree(_Py_path_config.program_name); - if (has_value) { - _Py_path_config.program_name = _PyMem_RawWcsdup(program_name); - } + _Py_path_config.program_name = has_value ? _PyMem_RawWcsdup(program_name) : NULL; PyMem_SetAllocator(PYMEM_DOMAIN_RAW, &old_alloc); @@ -302,9 +298,7 @@ _Py_SetProgramFullPath(const wchar_t *program_full_path) _PyMem_SetDefaultAllocator(PYMEM_DOMAIN_RAW, &old_alloc); PyMem_RawFree(_Py_path_config.program_full_path); - if (has_value) { - _Py_path_config.program_full_path = _PyMem_RawWcsdup(program_full_path); - } + _Py_path_config.program_full_path = has_value ? _PyMem_RawWcsdup(program_full_path) : NULL; PyMem_SetAllocator(PYMEM_DOMAIN_RAW, &old_alloc); pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy