From a1062777c341e54df9c970fa0ed9489226b3d2d9 Mon Sep 17 00:00:00 2001
From: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Date: Thu, 3 Nov 2022 07:29:11 -0700
Subject: [PATCH] gh-83004: Clean up refleak in _io initialisation (GH-98840)
(cherry picked from commit 1208037246eeab4c5c003f1651edfefb045e6fb7)
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
---
.../Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst | 1 +
Modules/_io/_iomodule.c | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
create mode 100644 Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst
diff --git a/Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst b/Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst
new file mode 100644
index 00000000000000..4de17abd063424
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst
@@ -0,0 +1 @@
+Clean up refleak on failed module initialisation in :mod:`_io`.
diff --git a/Modules/_io/_iomodule.c b/Modules/_io/_iomodule.c
index 38ef24637b7318..a7b2e984310d18 100644
--- a/Modules/_io/_iomodule.c
+++ b/Modules/_io/_iomodule.c
@@ -703,10 +703,10 @@ PyInit__io(void)
goto fail;
/* BlockingIOError, for compatibility */
- Py_INCREF(PyExc_BlockingIOError);
- if (PyModule_AddObject(m, "BlockingIOError",
- (PyObject *) PyExc_BlockingIOError) < 0)
+ if (PyModule_AddObjectRef(m, "BlockingIOError",
+ (PyObject *) PyExc_BlockingIOError) < 0) {
goto fail;
+ }
// Set type base classes
PyFileIO_Type.tp_base = &PyRawIOBase_Type;
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy