feat: new primitive for weakref.ref

BobTheBuidler · BobTheBuidler · commit 9eadb7ed2d8a · 2025-07-14T20:11:02.000Z
diff --git a/mypyc/primitives/registry.py b/mypyc/primitives/registry.py
@@ -371,4 +371,5 @@ def load_address_op(name: str, type: RType, src: str) -> LoadAddressDescription:
 import mypyc.primitives.list_ops
 import mypyc.primitives.misc_ops
 import mypyc.primitives.str_ops
-import mypyc.primitives.tuple_ops  # noqa: F401
+import mypyc.primitives.tuple_ops
+import mypyc.primitives.weakref_ops  # noqa: F401
diff --git a/mypyc/primitives/weakref_ops.py b/mypyc/primitives/weakref_ops.py
@@ -0,0 +1,22 @@
+from mypyc.ir.ops import ERR_MAGIC
+from mypyc.ir.rtypes import object_rprimitive, pointer_rprimitive
+from mypyc.primitives.registry import function_op
+
+# Weakref operations
+
+new_ref_op = function_op(
+    name="weakref.ReferenceType",
+    arg_types=[object_rprimitive],
+    return_type=object_rprimitive,
+    c_function_name="PyWeakref_NewRef",
+    extra_int_constants=[(0, pointer_rprimitive)],
+    error_kind=ERR_MAGIC,
+)
+
+new_ref__with_callback_op = function_op(
+    name="weakref.ReferenceType",
+    arg_types=[object_rprimitive, object_rprimitive],
+    return_type=object_rprimitive,
+    c_function_name="PyWeakref_NewRef",
+    error_kind=ERR_MAGIC,
+)
diff --git a/mypyc/test-data/irbuild-weakref.test b/mypyc/test-data/irbuild-weakref.test
@@ -0,0 +1,51 @@
+[case testWeakrefRef]
+import weakref
+from typing import Any, Callable
+def f(x: object) -> object:
+    return weakref.ref(x)
+
+[out]
+def f(x):
+    x, r0 :: object
+L0:
+    r0 = PyWeakref_NewRef(x, 0)
+    return r0
+
+[case testWeakrefRefCallback]
+import weakref
+from typing import Any, Callable
+def f(x: object, cb: Callable[[object], Any]) -> object:
+    return weakref.ref(x, cb)
+
+[out]
+def f(x, cb):
+    x, cb, r0 :: object
+L0:
+    r0 = PyWeakref_NewRef(x, cb)
+    return r0
+
+[case testFromWeakrefRef]
+from typing import Any, Callable
+from weakref import ref
+def f(x: object) -> object:
+    return ref(x)
+
+[out]
+def f(x):
+    x, r0 :: object
+L0:
+    r0 = PyWeakref_NewRef(x, 0)
+    return r0
+
+[case testFromWeakrefRefCallback]
+from typing import Any, Callable
+from weakref import ref
+def f(x: object, cb: Callable[[object], Any]) -> object:
+    return ref(x, cb)
+
+[out]
+def f(x, cb):
+    x, cb, r0 :: object
+L0:
+    r0 = PyWeakref_NewRef(x, cb)
+    return r0
diff --git a/mypyc/test-data/run-weakref.test b/mypyc/test-data/run-weakref.test
@@ -0,0 +1,25 @@
+# Test cases for weakrefs (compile and run)
+
+[case testWeakrefRef]
+import pytest  # type: ignore [import-not-found]
+from weakref import ref
+from mypy_extensions import mypyc_attr
+
+@mypyc_attr(native_class=False)
+class Object:
+    """some random weakreffable object"""
+    pass
+
+def test_weakref_ref():
+    obj = Object()
+    r = ref(obj)
+    assert r() is obj
+    obj = None
+    assert r() is None, r()
+
+def test_weakref_ref_with_callback():
+    obj = Object()
+    r = ref(obj, lambda x: x)
+    assert r() is obj
+    obj = None
+    assert r() is None, r()
diff --git a/mypyc/test/test_irbuild.py b/mypyc/test/test_irbuild.py
@@ -53,6 +53,7 @@
     "irbuild-constant-fold.test",
     "irbuild-glue-methods.test",
     "irbuild-math.test",
+    "irbuild-weakref.test",
 ]
 
 if sys.version_info >= (3, 10):
diff --git a/mypyc/test/test_run.py b/mypyc/test/test_run.py
@@ -70,6 +70,7 @@
     "run-singledispatch.test",
     "run-attrs.test",
     "run-signatures.test",
+    "run-weakref.test",
     "run-python37.test",
     "run-python38.test",
 ]
diff --git a/test-data/unit/lib-stub/weakref.pyi b/test-data/unit/lib-stub/weakref.pyi
@@ -0,0 +1,11 @@
+from collections.abc import Callable
+from typing import Any, Generic, TypeVar
+from typing_extensions import Self
+
+_T = TypeVar("_T")
+
+class ReferenceType(Generic[_T]):  # "weakref"
+    __callback__: Callable[[Self], Any]
+    def __new__(cls, o: _T, callback: Callable[[Self], Any] | None = ..., /) -> Self: ...
+
+ref = ReferenceType

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@`
`53`	`53`	`"irbuild-constant-fold.test",`
`54`	`54`	`"irbuild-glue-methods.test",`
`55`	`55`	`"irbuild-math.test",`
	`56`	`+ "irbuild-weakref.test",`
`56`	`57`	`]`
`57`	`58`
`58`	`59`	`if sys.version_info >= (3, 10):`
Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@`
`70`	`70`	`"run-singledispatch.test",`
`71`	`71`	`"run-attrs.test",`
`72`	`72`	`"run-signatures.test",`
	`73`	`+ "run-weakref.test",`
`73`	`74`	`"run-python37.test",`
`74`	`75`	`"run-python38.test",`
`75`	`76`	`]`