Skip to content

Many classes should be decorated as @final #11179

@sobolevn

Description

@sobolevn

While working on several mypy plugins I had often step on the fact you cannot subclass any of the mypy classes, because they are compiled with mypyc. It caused runtime TypeError in the plugin's code.

But, when I was trying to run mypy on the plugin's code - it was fine, no error was shown. Because type are not @final and mypy is not able to understand that this is a problem.

So, I propose to add explicit @final annotations to almost all types, exception:

  • Types with allow_interpreted_subclasses
  • Types that are subclassed inside mypy itself: Node, Expression, TypeQuery, etc

One more strong point to making this change is that many classes are not "designed" to be subclassed.
So, this should not be a problem.

Related #10125
Related #9602

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy