-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Description
Feature
Currently, comments can be added to a line to ignore either all errors (# type: ignore
), or a specific error code (eg. # type: ignore[call-arg]
). When a single statement spans multiple lines, the comment has to be added on the line that mypy "decides" is the one with the error (is it the first line of the expression, rather than first line of the statement?). In some cases, it would make sense to allow the comment to be on a different line of the same statement. I propose allowing it to be on any line of the statement, and therefore to apply to the whole statement.
Pitch
Sometimes it makes more sense for it to be another line, such as when importing something that mypy thinks does not exist, it makes sense to have the ignore on the same line as the attribute that is reported as not existing.
from typing import ( # ignore currently needs to be here
Union,
DoesNotExist, # type: ignore[error attr-defined]
)
Sometimes, a formatter like black changes a long line into a multiple line statement. The comment that was at the end of the line is moved to the end of the last line.
def foo(bar:int) -> str: ...
def baz() -> int: ...
a = ( # type: ignore[call-arg]
"something"
if baz() > 0 else
foo() # ignore currently needs to be here
) # formatters (eg. black) often put ignore here