Skip to content

Commit a3b0146

Browse files
authored
Actualiza a sphinx-autorun >= 2.0.0 (#3355)
Esta última versión incluye dos correcciones importantes: 1) la extensión ahora declara que sphinx puede llevar a cabo la lectura de los archivos .rst en paralelo (WhyNotHugo/sphinx-autorun#63), y 2) elimina unos RuntimeWarnings producto de un mal uso de la opción bufsize al crear objetos Popen (WhyNotHugo/sphinx-autorun#65). El primero de los problemas conllevaba a que nosotros tuviéramos que realizar manualmente el registro del plug-in, en vez de simplemente declararlo en "extensions". El segundo problema nos llevó a fijar un filtro con PYTHONWARNINGS con el cual se ignoraban todos los RuntimeWarning. Con esta última versión de sphinx-autorun, ambas soluciones parches ya no son necesarias. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
1 parent 1c21578 commit a3b0146

File tree

4 files changed

+4
-23
lines changed

4 files changed

+4
-23
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,5 +91,4 @@ jobs:
9191
# Construcción de la documentación
9292
- name: Construir documentación
9393
run: |
94-
# Normal build
95-
PYTHONWARNINGS=ignore::FutureWarning,ignore::RuntimeWarning sphinx-build -j auto -W --keep-going -b html -d cpython/Doc/_build/doctree -D language=es . cpython/Doc/_build/html
94+
sphinx-build -j auto -W --keep-going -b html -d cpython/Doc/_build/doctree -D language=es . cpython/Doc/_build/html

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ build: setup do_build
4444
.PHONY: do_build
4545
do_build:
4646
# Normal build
47-
PYTHONWARNINGS=ignore::FutureWarning,ignore::RuntimeWarning $(VENV)/bin/sphinx-build -j $(SPHINX_JOBS) -W --keep-going -b html -d $(OUTPUT_DOCTREE) -D language=$(LANGUAGE) . $(OUTPUT_HTML) && \
47+
$(VENV)/bin/sphinx-build -j $(SPHINX_JOBS) -W --keep-going -b html -d $(OUTPUT_DOCTREE) -D language=$(LANGUAGE) . $(OUTPUT_HTML) && \
4848
echo "Success! Open file://`pwd`/$(OUTPUT_HTML)/index.html, " \
4949
"or run 'make serve' to see them in http://localhost:8000";
5050

conf.py

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
exclude_patterns = _exclude_patterns
5555

5656
_extensions = [
57+
'sphinx_autorun',
5758
'sphinx_tabs.tabs',
5859
'sphinxemoji.sphinxemoji',
5960
]
@@ -126,22 +127,3 @@ def add_contributing_banner(app, doctree):
126127
app.srcdir = Path(os.getcwd() + '/cpython/Doc')
127128

128129
app.connect('doctree-read', add_contributing_banner)
129-
130-
# Import the sphinx-autorun manually to avoid this warning
131-
# TODO: Remove this code and use just ``extensions.append('sphinx_autorun')`` when
132-
# that issue gets fixed
133-
# See https://github.com/WhyNotHugo/sphinx-autorun/issues/17
134-
135-
# WARNING: the sphinx_autorun extension does not declare if it is safe for
136-
# parallel reading, assuming it isn't - please ask the extension author to
137-
# check and make it explicit
138-
# WARNING: doing serial read
139-
from sphinx_autorun import RunBlock, AutoRun
140-
app.add_directive('runblock', RunBlock)
141-
app.connect('builder-inited', AutoRun.builder_init)
142-
app.add_config_value('autorun_languages', AutoRun.config, 'env')
143-
return {
144-
'version': '0.1',
145-
'parallel_read_safe': True,
146-
'parallel_write_safe': True,
147-
}

requirements-own.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ pre-commit
88
Pygments>=2.17.0
99
PyICU
1010
setuptools
11-
sphinx-autorun
11+
sphinx-autorun>=2.0.0
1212
sphinxemoji
1313
sphinx-intl>=2.3.0
1414
sphinx-lint==0.7.0

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy