Hide GPG column if no GPG signatures in release (#2656)

hugovk · web-flow · commit bc51c6003f6e · 2024-11-15T09:07:58.000-06:00
diff --git a/downloads/templatetags/download_tags.py b/downloads/templatetags/download_tags.py
@@ -8,6 +8,11 @@ def strip_minor_version(version):
     return '.'.join(version.split('.')[:2])
 
 
+@register.filter
+def has_gpg(files: list) -> bool:
+    return any(f.gpg_signature_file for f in files)
+
+
 @register.filter
 def has_sigstore_materials(files):
     return any(
diff --git a/templates/downloads/release_detail.html b/templates/downloads/release_detail.html
@@ -1,6 +1,7 @@
 {% extends "base.html" %}
 {% load boxes %}
 {% load sitetree %}
+{% load has_gpg from download_tags %}
 {% load has_sigstore_materials from download_tags %}
 {% load has_sbom from download_tags %}
 {% load sort_windows from download_tags %}
@@ -51,7 +52,9 @@ <h1 class="page-title">Files</h1>
               <th>Description</th>
               <th>MD5 Sum</th>
               <th>File Size</th>
+              {% if release_files|has_gpg %}
               <th>GPG</th>
+              {% endif %}
               {% if release_files|has_sigstore_materials %}
               <th colspan="2"><a href="https://www.python.org/download/sigstore/">Sigstore</a></th>
               {% endif %}
@@ -68,7 +71,9 @@ <h1 class="page-title">Files</h1>
                 <td>{{ f.description }}</td>
                 <td>{{ f.md5_sum }}</td>
                 <td>{{ f.filesize|filesizeformat }}</td>
+                {% if release_files|has_gpg %}
                 <td>{% if f.gpg_signature_file %}<a href="{{ f.gpg_signature_file }}">SIG</a>{% endif %}</td>
+                {% endif %}
                 {% if release_files|has_sigstore_materials %}
                   {% if f.sigstore_bundle_file %}
                   <td colspan="2">{% if f.sigstore_bundle_file %}<a href="{{ f.sigstore_bundle_file}}">.sigstore</a>{% endif %}</td>
