address final (?) @slivingston comments

murrayrm · murrayrm · commit 0f0fad0de063 · 2025-01-12T17:29:24.000-08:00
diff --git a/control/tests/config_test.py b/control/tests/config_test.py
@@ -320,14 +320,30 @@ def test_system_indexing(self):
         sys2 = sys[1:, 1:]
         assert sys2.name == 'PRE' + sys.name + 'POST'
 
-    def test_repr_format(self):
+    @pytest.mark.parametrize("kwargs", [
+        {},
+        {'name': 'mysys'},
+        {'inputs': 1},
+        {'inputs': 'u'},
+        {'outputs': 1},
+        {'outputs': 'y'},
+        {'states': 1},
+        {'states': 'x'},
+        {'inputs': 1, 'outputs': 'y', 'states': 'x'},
+        {'dt': 0.1}
+    ])
+    def test_repr_format(self, kwargs):
         from ..statesp import StateSpace
         from numpy import array
 
-        sys = ct.ss([[1]], [[1]], [[1]], [[0]])
+        sys = ct.ss([[1]], [[1]], [[1]], [[0]], **kwargs)
         new = eval(repr(sys))
         for attr in ['A', 'B', 'C', 'D']:
-            assert getattr(sys, attr) == getattr(sys, attr)
+            assert getattr(new, attr) == getattr(sys, attr)
+        for prop in ['input_labels', 'output_labels', 'state_labels']:
+            assert getattr(new, attr) == getattr(sys, attr)
+        if 'name' in kwargs:
+            assert new.name == sys.name
 
 
 def test_config_context_manager():
diff --git a/control/tests/iosys_test.py b/control/tests/iosys_test.py
@@ -2351,7 +2351,7 @@ def test_iosys_repr(fcn, spec, expected, missing, format):
     sys.repr_format = format
     out = repr(sys)
     if format == 'eval':
-        assert re.search(expected, out) != None
+        assert re.search(expected, out) is not None
 
         if missing is not None:
             assert re.search(missing, out) is None
diff --git a/examples/repr_gallery.ipynb b/examples/repr_gallery.ipynb
@@ -7,7 +7,7 @@
    "source": [
     "# System Representation Gallery\n",
     "\n",
-    "This Jupyter notebook creates different types of systems and generates a variety of representations (`__repr__`, `__str__`) for those systems that can be used to compare different versions of python-control.  It is mainly intended for uses by developers to make sure there are no unexpected changes in representation formats, but also has some interest examples of different choices in system representation."
+    "This Jupyter notebook creates different types of systems and generates a variety of representations (`__repr__`, `__str__`) for those systems that can be used to compare different versions of python-control.  It is mainly intended for uses by developers to make sure there are no unexpected changes in representation formats, but also has some interesting examples of different choices in system representation."
    ]
   },
   {

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`"source": [`
`8`	`8`	`"# System Representation Gallery\n",`
`9`	`9`	`"\n",`
`10`		- "This Jupyter notebook creates different types of systems and generates a variety of representations (`__repr__`, `__str__`) for those systems that can be used to compare different versions of python-control. It is mainly intended for uses by developers to make sure there are no unexpected changes in representation formats, but also has some interest examples of different choices in system representation."
	`10`	+ "This Jupyter notebook creates different types of systems and generates a variety of representations (`__repr__`, `__str__`) for those systems that can be used to compare different versions of python-control. It is mainly intended for uses by developers to make sure there are no unexpected changes in representation formats, but also has some interesting examples of different choices in system representation."
`11`	`11`	`]`
`12`	`12`	`},`
`13`	`13`	`{`