Skip to content

Commit 062f8f6

Browse files
fix: argument type was not a tuple as expected
While adding type-hints mypy flagged this as an issue. The third argument to register_custom_action is supposed to be a tuple. It was being passed as a string rather than a tuple of strings.
1 parent 916a7fe commit 062f8f6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gitlab/v4/objects/merge_requests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ def pipelines(self, **kwargs):
234234
path = "%s/%s/pipelines" % (self.manager.path, self.get_id())
235235
return self.manager.gitlab.http_get(path, **kwargs)
236236

237-
@cli.register_custom_action("ProjectMergeRequest", tuple(), ("sha"))
237+
@cli.register_custom_action("ProjectMergeRequest", tuple(), ("sha",))
238238
@exc.on_http_error(exc.GitlabMRApprovalError)
239239
def approve(self, sha=None, **kwargs):
240240
"""Approve the merge request.

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy