test: use parentid to identify descendant group in reset_gitlab

Shreya-7 · Shreya-7 · commit 6619835aa6cf · 2022-10-31T08:34:36.000+05:30
diff --git a/tests/functional/conftest.py b/tests/functional/conftest.py
@@ -98,8 +98,7 @@ def reset_gitlab(gl: gitlab.Gitlab) -> None:
     for group in gl.groups.list():
 
         # skip deletion of a descendant group to prevent scenarios where parent group gets deleted leaving a dangling descendant whose deletion will throw 404s.
-        # descendant groups cannot contain the `/` special character: https://docs.gitlab.com/ee/user/reserved_names.html#limitations-on-project-and-group-names
-        if "/" in group.full_path:
+        if group.parent_id:
             logging.info(
                 f"Skipping deletion of {group.full_path} as it is a descendant group and will be removed when the parent group is deleted"
             )

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,7 @@ def reset_gitlab(gl: gitlab.Gitlab) -> None:`
`98`	`98`	`for group in gl.groups.list():`
`99`	`99`
`100`	`100`	`# skip deletion of a descendant group to prevent scenarios where parent group gets deleted leaving a dangling descendant whose deletion will throw 404s.`
`101`		- # descendant groups cannot contain the `/` special character: https://docs.gitlab.com/ee/user/reserved_names.html#limitations-on-project-and-group-names
`102`		`- if "/" in group.full_path:`
	`101`	`+ if group.parent_id:`
`103`	`102`	`logging.info(`
`104`	`103`	`f"Skipping deletion of {group.full_path} as it is a descendant group and will be removed when the parent group is deleted"`
`105`	`104`	`)`