chore: require f-strings

JohnVillalovos · JohnVillalovos · commit ce87be7da456 · 2022-06-01T07:58:53.000-07:00
We previously converted all string formatting to use f-strings. Enable
pylint check to enforce this.
diff --git a/gitlab/base.py b/gitlab/base.py
@@ -73,9 +73,9 @@ def __init__(
     ) -> None:
         if not isinstance(attrs, dict):
             raise GitlabParsingError(
-                "Attempted to initialize RESTObject with a non-dictionary value: "
-                "{!r}\nThis likely indicates an incorrect or malformed server "
-                "response.".format(attrs)
+                f"Attempted to initialize RESTObject with a non-dictionary value: "
+                f"{attrs!r}\nThis likely indicates an incorrect or malformed server "
+                f"response."
             )
         self.__dict__.update(
             {
diff --git a/pyproject.toml b/pyproject.toml
@@ -51,7 +51,6 @@ disable = [
     "arguments-renamed",
     "attribute-defined-outside-init",
     "broad-except",
-    "consider-using-f-string",
     "consider-using-generator",
     "consider-using-sys-exit",
     "cyclic-import",

Original file line number	Diff line number	Diff line change
`@@ -73,9 +73,9 @@ def __init__(`
`73`	`73`	`) -> None:`
`74`	`74`	`if not isinstance(attrs, dict):`
`75`	`75`	`raise GitlabParsingError(`
`76`		`- "Attempted to initialize RESTObject with a non-dictionary value: "`
`77`		`- "{!r}\nThis likely indicates an incorrect or malformed server "`
`78`		`- "response.".format(attrs)`
	`76`	`+ f"Attempted to initialize RESTObject with a non-dictionary value: "`
	`77`	`+ f"{attrs!r}\nThis likely indicates an incorrect or malformed server "`
	`78`	`+ f"response."`
`79`	`79`	`)`
`80`	`80`	`self.__dict__.update(`
`81`	`81`	`{`