feat(api): return result from SaveMixin.save()

kernelport · JohnVillalovos · commit e6258a4193a0 · 2022-01-13T14:57:42.000-08:00
Return the new object data when calling `SaveMixin.save()`. Also remove check for `None` value when calling `self.manager.update()` as that method only returns a dictionary. Closes: #1081
diff --git a/gitlab/mixins.py b/gitlab/mixins.py
@@ -525,30 +525,33 @@ def _get_updated_data(self) -> Dict[str, Any]:
 
         return updated_data
 
-    def save(self, **kwargs: Any) -> None:
+    def save(self, **kwargs: Any) -> Optional[Dict[str, Any]]:
         """Save the changes made to the object to the server.
 
         The object is updated to match what the server returns.
 
         Args:
             **kwargs: Extra options to send to the server (e.g. sudo)
 
+        Returns:
+            The new object data (*not* a RESTObject)
+
         Raise:
             GitlabAuthenticationError: If authentication is not correct
             GitlabUpdateError: If the server cannot perform the request
         """
         updated_data = self._get_updated_data()
         # Nothing to update. Server fails if sent an empty dict.
         if not updated_data:
-            return
+            return None
 
         # call the manager
         obj_id = self.encoded_id
         if TYPE_CHECKING:
             assert isinstance(self.manager, UpdateMixin)
         server_data = self.manager.update(obj_id, updated_data, **kwargs)
-        if server_data is not None:
-            self._update_attrs(server_data)
+        self._update_attrs(server_data)
+        return server_data
 
 
 class ObjectDeleteMixin(_RestObjectBase):
