diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py index 6b60583fa..f22229c07 100644 --- a/gitlab/v4/objects.py +++ b/gitlab/v4/objects.py @@ -2707,12 +2707,13 @@ def set_approvers( self._parent.get_id(), ) data = { + "name": "name", "approvals_required": approvals_required, "rule_type": "regular", "user_ids": approver_ids, "group_ids": approver_group_ids, } - self.gitlab.http_put(path, post_data=data, **kwargs) + self.gitlab.http_post(path, post_data=data, **kwargs) class ProjectMergeRequestAwardEmoji(ObjectDeleteMixin, RESTObject): diff --git a/tools/ee-test.py b/tools/ee-test.py index af1295788..3f756559f 100755 --- a/tools/ee-test.py +++ b/tools/ee-test.py @@ -56,12 +56,12 @@ def end_log(): ars = project1.approvalrules.list(all=True) assert len(ars) == 0 -project.approvalrules.create( +project1.approvalrules.create( {"name": "approval-rule", "approvals_required": 1, "group_ids": [group1.id]} ) ars = project1.approvalrules.list(all=True) assert len(ars) == 1 -ars[0].approvals_required == 2 +assert ars[0].approvals_required == 2 ars[0].save() ars = project1.approvalrules.list(all=True) assert len(ars) == 1
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies: