From 15a242c3303759b77b380c5b3ff9d1e0bf2d800c Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Sat, 18 Jun 2022 09:01:20 -0700 Subject: [PATCH] fix(cli): project-merge-request-approval-rule Using the CLI the command: gitlab project-merge-request-approval-rule list --mr-iid 1 --project-id foo/bar Would raise an exception. This was due to the fact that `_id_attr` and `_repr_attr` were set for keys which are not returned in the response. Add a unit test which shows the `repr` function now works. Before it did not. This is an EE feature so we can't functional test it. Closes: #2065 --- gitlab/v4/objects/merge_request_approvals.py | 3 +-- tests/unit/objects/test_project_merge_request_approvals.py | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py index a22bd2b57..eb243c7b4 100644 --- a/gitlab/v4/objects/merge_request_approvals.py +++ b/gitlab/v4/objects/merge_request_approvals.py @@ -165,8 +165,7 @@ def set_approvers( class ProjectMergeRequestApprovalRule(SaveMixin, ObjectDeleteMixin, RESTObject): - _id_attr = "approval_rule_id" - _repr_attr = "approval_rule" + _repr_attr = "name" id: int approval_rule_id: int merge_request_iid: int diff --git a/tests/unit/objects/test_project_merge_request_approvals.py b/tests/unit/objects/test_project_merge_request_approvals.py index 5a87552c3..27bbc84a4 100644 --- a/tests/unit/objects/test_project_merge_request_approvals.py +++ b/tests/unit/objects/test_project_merge_request_approvals.py @@ -168,6 +168,7 @@ def test_list_merge_request_approval_rules(project, resp_mr_approval_rules): assert len(approval_rules) == 1 assert approval_rules[0].name == approval_rule_name assert approval_rules[0].id == approval_rule_id + repr(approval_rules) # ensure that `repr()` doesn't raise an exception def test_delete_merge_request_approval_rule(project, resp_delete_mr_approval_rule): pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy