Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 7 commits
- 7 files changed
- 1 contributor
Commits on Jan 13, 2018
Commits on Jan 14, 2018
-
few fixes around parse_host, add a bunch of ipv6 test cases now that …
…we're doing that in regex
-
WIP: progress on moving away from inet_pton, but inet_aton is way too…
… permissive. And our IPv4 regex isn't doing us any favors, either. Now to face the question of whether that which is valid by socket.create_connection is valid in a URL, or if we should just switch to a full-regex approach, no socket modules
-
and now all the tests are passing using the regex-only approach. need…
… more negative tests now that we're not relying on the socket module, but this is something.
Commits on Jan 15, 2018
-
move all socket parsing/conditional inet_pton importing into tests pa…
…ckage, total coverage now up to 98%
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...i57_url_codecs