Tox: replace setup.py test with unittest discover

tiran · tiran · commit da85e98582fb · 2020-05-29T15:12:49.000+02:00
setup.py test is deprecated and causes issues with testing our code. There are cases where the wrong shared library is picked up. The ``unittest discover`` approach avoids building the extension twice. Install coverage < 5.0 to work around a problem with sqlite. python-ldap should move to pytest eventually. Fixes: #326 Signed-off-by: Christian Heimes <cheimes@redhat.com>
diff --git a/.coveragerc b/.coveragerc
@@ -1,9 +1,10 @@
 [run]
 branch = True
 source =
-    Lib/
-omit =
-    Lib/slapdtest.py
+   ldap
+   ldif
+   ldapurl
+   slapdtest
 
 [paths]
 source =
diff --git a/.travis.yml b/.travis.yml
@@ -67,10 +67,6 @@ matrix:
     - python: 3.6
       env: TOXENV=doc
   allow_failures:
-     - env:
-        - TOXENV=py39
-        - CFLAGS_std="-std=c99"
-        - WITH_GCOV=1
      - env:
         - TOXENV=pypy
 
@@ -88,7 +84,9 @@ env:
 
 install:
   - pip install "pip>=7.1.0"
-  - pip install tox-travis tox codecov coverage
+  - pip install tox-travis tox codecov
+  # See https://github.com/nedbat/coveragepy/issues/915
+  - pip install "coverage<5.0"
 
 script: CFLAGS="$CFLAGS_warnings $CFLAGS_std" tox
 
diff --git a/tox.ini b/tox.ini
@@ -9,50 +9,58 @@ envlist = py27,py34,py35,py36,py37,py38,py39,{py2,py3}-nosasltls,doc,py3-trace,c
 minver = 1.8
 
 [testenv]
-deps = coverage
+# coverag 5.0.2 is failing with "sqlite3.OperationalError: disk I/O error"
+# https://github.com/nedbat/coveragepy/issues/915
+deps = coverage < 5.0
 passenv = WITH_GCOV
 # - Enable BytesWarning
 # - Turn all warnings into exceptions.
 # - 'ignore:the imp module is deprecated' is required to ignore import of 'imp'
 #   in distutils. Python < 3.6 use PendingDeprecationWarning; Python >= 3.6 use
 #   DeprecationWarning.
+# - 'ignore:lib2to3 package' for Python 3.9
 commands = {envpython} -bb -Werror \
     "-Wignore:the imp module is deprecated:DeprecationWarning" \
     "-Wignore:the imp module is deprecated:PendingDeprecationWarning" \
     "-Wignore:Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working:DeprecationWarning" \
-    -m coverage run --parallel setup.py \
-        clean --all \
-        test
+    "-Wignore:lib2to3 package is deprecated and may not be able to parse Python 3.10+:PendingDeprecationWarning" \
+    -m coverage run --parallel -m unittest discover -v -s Tests -p 't_*'
 
 [testenv:py27]
 # No warnings with Python 2.7
 passenv = {[testenv]passenv}
-commands = {envpython} \
-    -m coverage run --parallel setup.py test
+commands =
+    {envpython} -m coverage run --parallel \
+        -m unittest discover -v -s Tests -p 't_*'
 
 [testenv:py34]
 # No warnings with Python 3.4
 passenv = {[testenv]passenv}
-commands = {envpython} \
-    -m coverage run --parallel setup.py test
+commands = {[testenv:py27]commands}
 
 [testenv:py2-nosasltls]
 basepython = python2
-deps = {[testenv]deps}
+# don't install, install dependencies manually
+skip_install = true
+deps =
+    {[testenv]deps}
+    pyasn1
+    pyasn1_modules
 passenv = {[testenv]passenv}
 setenv =
     CI_DISABLED=LDAPI:SASL:TLS
-# rebuild without SASL and TLS, run without LDAPI
-commands = {envpython} \
-    -m coverage run --parallel setup.py \
-        clean --all \
-        build_ext -UHAVE_SASL,HAVE_TLS \
-        test
+# build and install without SASL and TLS, run without LDAPI
+commands =
+    {envpython} setup.py clean --all
+    {envpython} setup.py build_ext -UHAVE_SASL,HAVE_TLS
+    {envpython} setup.py install --single-version-externally-managed --root=/
+    {[testenv:py27]commands}
 
 [testenv:py3-nosasltls]
 basepython = python3
-deps = {[testenv]deps}
-passenv = {[testenv]passenv}
+skip_install = {[testenv:py2-nosasltls]skip_install}
+deps = {[testenv:py2-nosasltls]deps}
+passenv = {[testenv:py2-nosasltls]passenv}
 setenv = {[testenv:py2-nosasltls]setenv}
 commands = {[testenv:py2-nosasltls]commands}
 
