Check valid connection in LDAPObject.set/get_option

tiran · tiran · commit e182bd2c4089 · 2020-05-29T12:18:05.000+02:00
set_option() and get_option() now verify that LDAPObject is valid. This
fixes an assertion error and possible segfault after unbind_ext().

Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
diff --git a/Modules/LDAPObject.c b/Modules/LDAPObject.c
@@ -1391,6 +1391,8 @@ l_ldap_set_option(PyObject *self, PyObject *args)
 
     if (!PyArg_ParseTuple(args, "iO:set_option", &option, &value))
         return NULL;
+    if (not_valid(self))
+        return NULL;
     if (!LDAP_set_option((LDAPObject *)self, option, value))
         return NULL;
     Py_INCREF(Py_None);
@@ -1406,6 +1408,8 @@ l_ldap_get_option(PyObject *self, PyObject *args)
 
     if (!PyArg_ParseTuple(args, "i:get_option", &option))
         return NULL;
+    if (not_valid(self))
+        return NULL;
     return LDAP_get_option((LDAPObject *)self, option);
 }
 
