Lib/ldap: Provide _trace_level and _trace_file in non-debug mode

encukou · encukou · commit ecd533b2ec77 · 2018-07-30T20:18:53.000+02:00
All use of these attributes *should* be guarded by `if __debug__`. However, that's not always the case. Providing different API based on __debug__ is unnecessarily fragile. This is intended as a quick fix for a maintenance release. Fixes: #226
diff --git a/Lib/ldap/__init__.py b/Lib/ldap/__init__.py
@@ -23,6 +23,13 @@
     _trace_file = open(_trace_file, 'a')
     atexit.register(_trace_file.close)
   _trace_stack_limit = None
+else:
+  # Any use of the _trace attributes should be guarded by `if __debug__`,
+  # so they should not be needed here.
+  # But, providing different API for debug mode is unnecessarily fragile.
+  _trace_level = 0
+  _trace_file = sys.stderr
+  _trace_stack_limit = None
 
 import _ldap
 assert _ldap.__version__==__version__, \
