feat: avoid to fail on DecodeErrors when logging

azmeuk · azmeuk · commit f3aea4b09c0a · 2025-04-03T12:46:09.000+02:00
diff --git a/slapd/__init__.py b/slapd/__init__.py
@@ -342,7 +342,7 @@ def _test_config(self):
         ]
         p = subprocess.run(popen_list, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
         if p.returncode != 0:
-            self.logger.error(p.stdout.decode("utf-8"))
+            self.logger.error(p.stdout.decode("utf-8", errors="replace"))
             raise RuntimeError("configuration test failed")
         self.logger.info("config ok: %s", self._slapd_conf)
 
@@ -479,14 +479,14 @@ def _cli_popen(
         self.logger.debug("Run command: %r", " ".join(args))
         proc = subprocess.run(args, input=stdin_data, capture_output=True)
         self.logger.debug(
-            "stdin_data=%s", stdin_data.decode("utf-8") if stdin_data else stdin_data
+            "stdin_data=%s", stdin_data.decode("utf-8", errors="replace") if stdin_data else stdin_data
         )
 
         if proc.stdout is not None:
-            self.logger.debug("stdout=%s", proc.stdout.decode("utf-8"))
+            self.logger.debug("stdout=%s", proc.stdout.decode("utf-8", errors="replace"))
 
         if proc.stderr is not None:
-            self.logger.debug("stderr=%s", proc.stderr.decode("utf-8"))
+            self.logger.debug("stderr=%s", proc.stderr.decode("utf-8", errors="replace"))
 
         if proc.returncode not in expected:
             raise RuntimeError(
