From 0383a3deab42d3c75fc8ffe84a8199b2654d5c6d Mon Sep 17 00:00:00 2001 From: Hiroki Teranishi Date: Thu, 13 Jun 2024 01:50:51 +0900 Subject: [PATCH 1/2] Fix resolver for jsonschema validator created by `SchemaValidatorsFactory`. --- openapi_core/validation/schemas/factories.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/openapi_core/validation/schemas/factories.py b/openapi_core/validation/schemas/factories.py index a71d5139..11be59a5 100644 --- a/openapi_core/validation/schemas/factories.py +++ b/openapi_core/validation/schemas/factories.py @@ -57,11 +57,10 @@ def create( format_checker = self.get_format_checker( format_validators, extra_format_validators ) - resolver = schema.accessor.resolver # type: ignore - with schema.open() as schema_dict: + with schema.resolve() as resolved: jsonschema_validator = self.schema_validator_class( - schema_dict, - _resolver=resolver, + resolved.contents, + _resolver=resolved.resolver, format_checker=format_checker, ) From 7d0f325098f540048ad81ed34cbd77065ed9a02f Mon Sep 17 00:00:00 2001 From: p1c2u Date: Thu, 20 Jun 2024 20:54:26 +0000 Subject: [PATCH 2/2] Fix resolver for jsonschema validator test --- .../data/v3.0/parent-reference/openapi.yaml | 7 +++++ .../v3.0/parent-reference/paths/books.yaml | 10 +++++++ .../v3.0/parent-reference/schemas/book.yaml | 9 ++++++ .../validation/test_parent_reference.py | 29 +++++++++++++++++++ 4 files changed, 55 insertions(+) create mode 100644 tests/integration/data/v3.0/parent-reference/openapi.yaml create mode 100644 tests/integration/data/v3.0/parent-reference/paths/books.yaml create mode 100644 tests/integration/data/v3.0/parent-reference/schemas/book.yaml create mode 100644 tests/integration/validation/test_parent_reference.py diff --git a/tests/integration/data/v3.0/parent-reference/openapi.yaml b/tests/integration/data/v3.0/parent-reference/openapi.yaml new file mode 100644 index 00000000..51150416 --- /dev/null +++ b/tests/integration/data/v3.0/parent-reference/openapi.yaml @@ -0,0 +1,7 @@ +openapi: "3.0.0" +info: + title: sample + version: "0.1" +paths: + /books: + $ref: "./paths/books.yaml" \ No newline at end of file diff --git a/tests/integration/data/v3.0/parent-reference/paths/books.yaml b/tests/integration/data/v3.0/parent-reference/paths/books.yaml new file mode 100644 index 00000000..d625f4f5 --- /dev/null +++ b/tests/integration/data/v3.0/parent-reference/paths/books.yaml @@ -0,0 +1,10 @@ +get: + responses: + "200": + description: OK + content: + application/json: + schema: + type: array + items: + $ref: "../schemas/book.yaml#/Book" \ No newline at end of file diff --git a/tests/integration/data/v3.0/parent-reference/schemas/book.yaml b/tests/integration/data/v3.0/parent-reference/schemas/book.yaml new file mode 100644 index 00000000..1bf35402 --- /dev/null +++ b/tests/integration/data/v3.0/parent-reference/schemas/book.yaml @@ -0,0 +1,9 @@ +Book: + type: object + properties: + id: + $ref: "#/BookId" + title: + type: string +BookId: + type: string \ No newline at end of file diff --git a/tests/integration/validation/test_parent_reference.py b/tests/integration/validation/test_parent_reference.py new file mode 100644 index 00000000..df526835 --- /dev/null +++ b/tests/integration/validation/test_parent_reference.py @@ -0,0 +1,29 @@ +import json + +import pytest +from jsonschema_path import SchemaPath + +from openapi_core import Config +from openapi_core import OpenAPI +from openapi_core.testing import MockRequest +from openapi_core.testing import MockResponse + + +class TestParentReference: + + spec_path = "data/v3.0/parent-reference/openapi.yaml" + + @pytest.fixture + def openapi(self, content_factory): + content, base_uri = content_factory.from_file(self.spec_path) + spec = SchemaPath.from_dict(content, base_uri=base_uri) + config = Config(spec_base_uri=base_uri) + return OpenAPI(spec, config=config) + + def test_valid(self, openapi): + request = MockRequest(host_url="", method="GET", path="/books") + response = MockResponse( + data=json.dumps([{"id": "BOOK:01", "title": "Test Book"}]).encode() + ) + + openapi.validate_response(request, response) pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy