Fix #284: implement "is_compatible" with method

tomschr · Lexicality · tlaferriere · tomschr · commit 39ee6b1aa5e8 · 2022-12-20T18:07:17.000+01:00
* Implement Version.is_compatible() method
* Update test cases
* Update documentation
* Rename isvalid method to is_valid to make it consistent
  with is_compatible

The algorithm checks:

* if the two majors are different, it's incompatible
* if the two majors are equal, but the minor of the new
  version is lower than the old, it's incompatible
* if both prereleases are present and different,
  it's incompatible
* otherwise it's compatible

The algorithm does *not* check patches!

Co-authored-by: Lexi Robinson &lt;lexi@lexi.org.uk&gt;
Co-authored-by: Thomas Laferriere &lt;tlaferriere@users.noreply.github.com&gt;
Co-authored-by: Raphael Krupinski &lt;rafalkrupinski@users.noreply.github.com&gt;
diff --git a/.gitignore b/.gitignore
@@ -268,3 +268,6 @@ fabric.properties
 
 docs/_api
 !docs/_api/semver.__about__.rst
+
+# For node
+node_modules/
diff --git a/changelog.d/284.deprecation.rst b/changelog.d/284.deprecation.rst
@@ -0,0 +1,5 @@
+Deprecate the use of :meth:`Version.isvalid`.
+
+Rename :meth:`Version.isvalid <semver.version.Version.isvalid>`
+to :meth:`Version.is_valid <semver.version.Version.is_valid>`
+for consistency reasons with :meth:`Version.is_compatible <semver.version.Version.is_compatible>`
diff --git a/changelog.d/284.doc.rst b/changelog.d/284.doc.rst
@@ -0,0 +1 @@
+Document deprecation of :meth:`Version.isvalid`.
diff --git a/changelog.d/284.feature.rst b/changelog.d/284.feature.rst
@@ -0,0 +1 @@
+Implement :meth:`Version.is_compatible <semver.version.Version.is_compatible>` to make "is self compatible with X".
diff --git a/docs/conf.py b/docs/conf.py
@@ -118,8 +118,8 @@ def find_version(*file_paths):
 # Markup to shorten external links
 # See https://www.sphinx-doc.org/en/master/usage/extensions/extlinks.html
 extlinks = {
-    "gh": ("https://github.com/python-semver/python-semver/issues/%s", "#"),
-    "pr": ("https://github.com/python-semver/python-semver/pull/%s", "PR #"),
+    "gh": ("https://github.com/python-semver/python-semver/issues/%s", "#%s"),
+    "pr": ("https://github.com/python-semver/python-semver/pull/%s", "PR #%s"),
 }
 
 # -- Options for HTML output ----------------------------------------------
diff --git a/docs/migration/migratetosemver3.rst b/docs/migration/migratetosemver3.rst
@@ -3,8 +3,9 @@
 Migrating from semver2 to semver3
 =================================
 
-This document describes the visible differences for
+This section describes the visible differences for
 users and how your code stays compatible for semver3.
+Some changes are backward incompatible.
 
 Although the development team tries to make the transition
 to semver3 as smooth as possible, at some point change
@@ -34,9 +35,16 @@ Use semver.cli instead of semver
 --------------------------------
 
 All functions related to CLI parsing are moved to :mod:`semver.cli`.
-If you are such functions, like :func:`semver.cmd_bump <semver.cli.cmd_bump>`,
+If you need such functions, like :func:`semver.cmd_bump <semver.cli.cmd_bump>`,
 import it from :mod:`semver.cli` in the future:
 
 .. code-block:: python
 
    from semver.cli import cmd_bump
+
+
+Use semver.Version.is_valid instead of semver.Version.isvalid
+-------------------------------------------------------------
+
+The pull request :pr:`284` introduced the method :meth:`Version.is_compatible <semver.Version.is_compatible>`. To keep consistency, the development team
+decided to rename the :meth:`isvalid <semver.Version.isvalid>` to :meth:`is_valid <semver.Version.is_valid>`.
diff --git a/docs/migration/replace-deprecated-functions.rst b/docs/migration/replace-deprecated-functions.rst
@@ -31,6 +31,18 @@ them with code which is compatible for future versions:
 
   Likewise with the other module level functions.
 
+* :func:`semver.Version.isvalid`
+
+   Replace it with :meth:`semver.Version.is_valid`:
+
+  .. code-block:: python
+
+     >>> s1 = semver.Version.isvalid("1.2.3")
+     >>> s2 = semver.Version.is_valid("1.2.3")
+     >>> s1 == s2
+     True
+
+
 * :func:`semver.finalize_version`
 
   Replace it with :func:`semver.Version.finalize_version`:
diff --git a/docs/usage/check-compatible-semver-version.rst b/docs/usage/check-compatible-semver-version.rst
@@ -0,0 +1,56 @@
+Checking for a Compatible Semver Version
+========================================
+
+If you need to check if a semver version is compatible
+with another semver version, use :meth:`Version.is_compatible <semver.Version.is_compatible>`.
+
+A version `a` is compatible with another version `b` if:
+
+* Both types are of type :class:`Version <semver.version.Version>`.
+* The two majors parts equal.
+* The two major parts are equal and the minor of ``a`` is lower
+  than the minor of ``b``.
+* Both pre-releases are present and equal.
+
+In all other cases, it's incompatible.
+
+Keep in mind, the method *does not* check patches!
+
+
+.. code-block:: python
+
+    # Two different majors:
+    >>> a = Version(1, 1, 1) # This is "A"
+    >>> b = Version(2, 0, 0) # This is "B"
+    >>> a.is_compatible(b)
+    False
+
+    # The same two majors and minors:
+    >>> b = Version(1, 1, 0) # This is another "B"
+    >>> a.is_compatible(b)
+    True
+
+    # The same two majors, but B.minor < A.minor:
+    >>> b = Version(1, 0, 0) # This is another "B"
+    >>> a.is_compatible(b)
+    False
+
+    # Checking compatibility between release and pre-release:
+    >>> b = Version(1,0,0,'rc1.')
+    >>> a.is_compatible(b)
+    False
+
+    # But pre-release and release:
+    >>> b.is_compatible(a)
+    False
+
+All major zero versions are incompatible with anything but itself:
+
+.. code-block:: python
+
+    >>> Version(0,1,0).is_compatible(Version(0,1,1))
+    False
+
+    # Only identical versions are compatible for major zero versions:
+    >>> Version(0,1,0).is_compatible(Version(0,1,0))
+    True
diff --git a/docs/usage/check-valid-semver-version.rst b/docs/usage/check-valid-semver-version.rst
@@ -6,7 +6,7 @@ classmethod :func:`Version.isvalid <semver.version.Version.isvalid>`:
 
 .. code-block:: python
 
-    >>> Version.isvalid("1.0.0")
+    >>> Version.is_valid("1.0.0")
     True
-    >>> Version.isvalid("invalid")
+    >>> Version.is_valid("invalid")
     False
diff --git a/docs/usage/index.rst b/docs/usage/index.rst
@@ -8,6 +8,7 @@ Using semver
    create-a-version
    parse-version-string
    check-valid-semver-version
+   check-compatible-semver-version
    access-parts-of-a-version
    access-parts-through-index
    replace-parts-of-a-version
diff --git a/src/semver/cli.py b/src/semver/cli.py
@@ -54,7 +54,7 @@ def cmd_check(args: argparse.Namespace) -> None:
 
     :param args: The parsed arguments
     """
-    if Version.isvalid(args.version):
+    if Version.is_valid(args.version):
         return None
     raise ValueError("Invalid version %r" % args.version)
 
diff --git a/src/semver/version.py b/src/semver/version.py
@@ -642,7 +642,7 @@ def replace(self, **parts: Union[int, Optional[str]]) -> "Version":
             raise TypeError(error)
 
     @classmethod
-    def isvalid(cls, version: str) -> bool:
+    def is_valid(cls, version: str) -> bool:
         """
         Check if the string is a valid semver version.
 
@@ -658,6 +658,38 @@ def isvalid(cls, version: str) -> bool:
         except ValueError:
             return False
 
+    def is_compatible(self, other: "Version") -> bool:
+        """
+        Check if current version is compatible with other version.
+
+        The algorithm checks:
+
+        * if the two majors are different, it's incompatible
+        * if the two majors are equal, but the minor of ``other``
+          is lower than self.minor, it's incompatible
+        * if both pre-releases are present and different,
+          it's incompatible
+        * otherwise it's compatible
+
+        The algorithm does *not* check patches.
+
+        :param other: the version to check for compatibility
+        :return: True, if ``other`` is compatible with the old version,
+                 otherwise False
+        """
+        if not isinstance(other, Version):
+            raise TypeError(f"Expected a Version type but got {type(other)}")
+
+        # All major-0 versions should be incompatible with anything but itself
+        if (0 == self.major == other.major) and (self[:4] != other[:4]):
+            return False
+
+        return (
+            (self.major == other.major)
+            and (other.minor >= self.minor)
+            and (self.prerelease == other.prerelease)
+        )
+
 
 #: Keep the VersionInfo name for compatibility
 VersionInfo = Version
diff --git a/tests/test_semver.py b/tests/test_semver.py
@@ -73,10 +73,65 @@ def test_should_be_able_to_use_integers_as_prerelease_build():
 
 
 def test_should_versioninfo_isvalid():
-    assert Version.isvalid("1.0.0") is True
-    assert Version.isvalid("foo") is False
+    assert Version.is_valid("1.0.0") is True
+    assert Version.is_valid("foo") is False
 
 
 def test_versioninfo_compare_should_raise_when_passed_invalid_value():
     with pytest.raises(TypeError):
         Version(1, 2, 3).compare(4)
+
+
+@pytest.mark.parametrize(
+    "old, new",
+    [
+        ((1, 2, 3), (1, 2, 3)),
+        ((1, 2, 3), (1, 2, 4)),
+        ((1, 2, 4), (1, 2, 3)),
+        ((1, 2, 3, "rc.0"), (1, 2, 4, "rc.0")),
+        ((0, 1, 0), (0, 1, 0)),
+    ],
+)
+def test_should_succeed_compatible_match(old, new):
+    old = Version(*old)
+    new = Version(*new)
+    assert old.is_compatible(new)
+
+
+@pytest.mark.parametrize(
+    "old, new",
+    [
+        ((1, 1, 0), (1, 0, 0)),
+        ((2, 0, 0), (1, 5, 0)),
+        ((1, 2, 3, "rc.1"), (1, 2, 3, "rc.0")),
+        ((1, 2, 3, "rc.1"), (1, 2, 4, "rc.0")),
+        ((0, 1, 0), (0, 1, 1)),
+        ((1, 0, 0), (1, 0, 0, "rc1")),
+        ((1, 0, 0, "rc1"), (1, 0, 0)),
+    ],
+)
+def test_should_fail_compatible_match(old, new):
+    old = Version(*old)
+    new = Version(*new)
+    assert not old.is_compatible(new)
+
+
+@pytest.mark.parametrize(
+    "wrongtype",
+    [
+        "wrongtype",
+        dict(a=2),
+        list(),
+    ],
+)
+def test_should_fail_with_incompatible_type_for_compatible_match(wrongtype):
+    with pytest.raises(TypeError, match="Expected a Version type .*"):
+        v = Version(1, 2, 3)
+        v.is_compatible(wrongtype)
+
+
+def test_should_succeed_with_compatible_subclass_for_is_compatible():
+    class CustomVersion(Version):
+        ...
+
+    assert CustomVersion(1, 0, 0).is_compatible(Version(1, 0, 0))
diff --git a/tox.ini b/tox.ini
@@ -18,8 +18,8 @@ python =
 
 [testenv]
 description = Run test suite for {basepython}
-allowlist_externals = make
 skip_install = true
+allowlist_externals = make
 commands = pytest {posargs:}
 deps =
     pytest

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Document deprecation of :meth:`Version.isvalid`.
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Implement :meth:`Version.is_compatible <semver.version.Version.is_compatible>` to make "is self compatible with X".