Skip to content

Commit 93eebfe

Browse files
tomschrtlaferriere
andcommitted
Apply suggestions from code review
Co-authored-by: Thomas Laferriere <t.laferriere@hotmail.ca>
1 parent 6f64b71 commit 93eebfe

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/semver/version.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,14 @@ def _check_types(*args):
182182
"{!r} is negative. A version can only be positive.".format(name)
183183
)
184184

185-
prerelease = cls._ensure_str(prerelease or verlist[3]) # type: ignore
186-
build = cls._ensure_str(build or verlist[4]) # type: ignore
185+
if isinstance(prerelease, int):
186+
self._prerelease = prerelease
187+
else:
188+
self._prerelease = cls._ensure_str(prerelease or verlist[3])
189+
if isinstance(build, int):
190+
self._build = build
191+
else:
192+
self._build = cls._ensure_str(build or verlist[4])
187193

188194
self._major = version_parts["major"]
189195
self._minor = version_parts["minor"]
@@ -215,9 +221,7 @@ def cmp_prerelease_tag(a, b):
215221
return _cmp(len(a), len(b))
216222

217223
@classmethod
218-
def _ensure_str(
219-
cls, s: Optional[StringOrInt], encoding="UTF-8"
220-
) -> Optional[StringOrInt]:
224+
def _ensure_str(cls, s: Optional[String], encoding="UTF-8") -> Optional[str]:
221225
"""
222226
Ensures string type regardless if argument type is str or bytes.
223227

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy