@@ -18,8 +18,8 @@ First, take the time to look into our GitHub `issues`_ tracker if
18
18
this already covered. If not, changes are good that we avoid double work.
19
19
20
20
21
- Fixing Bugs and Implementing New Features
22
- -----------------------------------------
21
+ Prerequisites
22
+ -------------
23
23
24
24
Before you make changes to the code, we would highly appreciate if you
25
25
consider the following general requirements:
@@ -29,12 +29,6 @@ consider the following general requirements:
29
29
* Check if your feature is covered by the Semantic Versioning specification.
30
30
If not, ask on its GitHub project https://github.com/semver/semver.
31
31
32
- * Write test cases if you implement a new feature.
33
-
34
- * Test also for side effects of your new feature and run the complete
35
- test suite.
36
-
37
- * Document the new feature, see :ref: `doc ` for details.
38
32
39
33
40
34
Modifying the Code
@@ -61,20 +55,23 @@ We recommend the following workflow:
61
55
62
56
$ git checkout -b feature/NAME_OF_YOUR_FEATURE
63
57
64
- #. Work on your branch. Commit your work.
58
+ #. Work on your branch and create a pull request:
65
59
66
- #. Write test cases and run the test suite, see :ref: `testsuite ` for details.
60
+ a. Write test cases and run the complete test suite, see :ref: `testsuite `
61
+ for details.
67
62
68
- #. Create a `pull request `_. Describe in the pull request what you did
69
- and why. If you have open questions, ask.
63
+ b. Write a changelog entry, see section :ref: `changelog `.
70
64
71
- #. Wait for feedback. If you receive any comments, address these.
65
+ c. If you have implemented a new feature, document it into our
66
+ documentation to help our reader. See section :ref: `doc ` for
67
+ further details.
72
68
73
- #. After your pull request got accepted, delete your branch.
69
+ d. Create a `pull request `_. Describe in the pull request what you did
70
+ and why. If you have open questions, ask.
74
71
75
- #. Use the `` clean `` command to remove build and test files and folders::
72
+ #. Wait for feedback. If you receive any comments, address these.
76
73
77
- $ python setup.py clean
74
+ #. After your pull request got accepted, delete your branch.
78
75
79
76
80
77
.. _testsuite :
@@ -227,8 +224,8 @@ documentation includes:
227
224
228
225
.. _changelog :
229
226
230
- Changelog
231
- ---------
227
+ Adding a Changelog Entry
228
+ ------------------------
232
229
233
230
.. include :: ../changelog.d/README.rst
234
231
:start-after: -text-begin-
@@ -241,3 +238,4 @@ Changelog
241
238
.. _Semantic Versioning : https://semver.org
242
239
.. _Sphinx style : https://sphinx-rtd-tutorial.readthedocs.io/en/latest/docstrings.html
243
240
.. _tox : https://tox.readthedocs.org/
241
+
0 commit comments