-
Notifications
You must be signed in to change notification settings - Fork 97
Closed
Labels
EnhancementNot a bug, but increases or improves in value, quality, desirability, or attractivenessNot a bug, but increases or improves in value, quality, desirability, or attractivenessInfraAll about infrastructure (GitHub Action, project build etc.)All about infrastructure (GitHub Action, project build etc.)QuestionUnclear or open issue subject for debateUnclear or open issue subject for debateRelease_3.x.yOnly for the major release 3Only for the major release 3
Description
Situation
As we saw in issue #224, the setup.py
script can be tricky. Usually, a setup.py
script should describe its metadata, but should avoid any "complicated" command logic.
We had this situation already in the past: in issue #148 we discouraged the use of python setup.py test
in documentation.
Proposal
I propose to remove the Tox
and Clean
classes in the setup.py
script for the following reasons:
- We discouraged it already in issue Doc: Remove recommendation of "setup.py test" in Contribute Section #148, so the script should not offer something that isn't advertised in our documentation.
- According to Ionel Cristian Mărieș in "The setup script" section of his blog, he recommends a
setup.py
script should be "as simple as possible". - The less command logic we have, the better we can switch to other packaging tools if this would be needed in the future.
Maybe I miss a good reason, but at the moment, I think they are not really that essential, right?
Questions
- Should we simplify the script? Is that be a feature we would like to have
- If yes, for which version should we implement this?
@python-semver/reviewers What do you think about this proposal? 😉
Metadata
Metadata
Assignees
Labels
EnhancementNot a bug, but increases or improves in value, quality, desirability, or attractivenessNot a bug, but increases or improves in value, quality, desirability, or attractivenessInfraAll about infrastructure (GitHub Action, project build etc.)All about infrastructure (GitHub Action, project build etc.)QuestionUnclear or open issue subject for debateUnclear or open issue subject for debateRelease_3.x.yOnly for the major release 3Only for the major release 3