Skip to content

Fix #309: Make some functions private #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2020
Merged

Fix #309: Make some functions private #320

merged 1 commit into from
Nov 10, 2020

Conversation

tomschr
Copy link
Member

@tomschr tomschr commented Nov 8, 2020 •
edited
Loading

This PR fixes #309 and contains:

  • Rename comparator -> _comparator, cmp -> _cmp
  • Remove ensure_str and integrate it into Version.parse
  • Rework tests in test_typeerror-274.py
  • Move _nat_cmp to Version and make it a class method
  • Remove private functions from API documentation

@tomschr tomschr added the Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness label Nov 8, 2020
@tomschr tomschr requested a review from a team November 8, 2020 14:26
@tomschr tomschr self-assigned this Nov 8, 2020
@tomschr tomschr marked this pull request as ready for review November 8, 2020 19:40
@tomschr tomschr force-pushed the feature/309-private-functions branch from b65619d to 42fd668 Compare November 8, 2020 19:50
tlaferriere
tlaferriere suggested changes Nov 10, 2020
View reviewed changes
@tomschr
Fix python-semver#309: Make some functions private
201d783 
Make private function in semver.version module:

* Rename comparator -> _comparator, cmp -> _cmp
* Remove ensure_str and integrate it into Version.parse
* Rework tests in test_typeerror-274.py
* Move _nat_cmp to Version and make it a class method
* Remove private functions from API documentation
@tomschr tomschr force-pushed the feature/309-private-functions branch from 42fd668 to 201d783 Compare November 10, 2020 07:36
@tomschr tomschr merged commit 13ad4ab into python-semver:master Nov 10, 2020
@tomschr tomschr deleted the feature/309-private-functions branch November 10, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlaferriere tlaferriere tlaferriere requested changes

Assignees

@tomschr tomschr

Labels
Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework some "private" functions in semver.version?
2 participants
@tomschr @tlaferriere
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy